Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GS/OpenGL: Use shader+draw for CopyRectConv #5029

Merged
merged 2 commits into from
Nov 22, 2021
Merged

GS/OpenGL: Use shader+draw for CopyRectConv #5029

merged 2 commits into from
Nov 22, 2021

Conversation

stenzek
Copy link
Member

@stenzek stenzek commented Nov 18, 2021

Description of Changes

Apparently using glCopyTextureSubImage2D was causing memory leaks in Evolution Snowboarding on NVIDIA and Intel drivers. For some reason it's fine for me on AMD...

Fixes #5017

Rationale behind Changes

Leaks bad

Suggested Testing Steps

Make sure games which need colclip clamping off aren't affected (e.g. FFX-2 opening FMV).

@refractionpcsx2
Copy link
Member

refractionpcsx2 commented Nov 18, 2021

Just to note, Evolution Snowboarding still runs like ass because it does Colclip and has a LOT of draw calls which is slow on OpenGL, so probably better to use D3D for this game

@seta-san
Copy link
Contributor

the speed jump is amazing but there is now a weird shadow box that is around your playable character.

@refractionpcsx2
Copy link
Member

the speed jump is amazing but there is now a weird shadow box that is around your playable character.

Have you got a picture? I don't see it

@seta-san
Copy link
Contributor

box
2

@seta-san
Copy link
Contributor

seta-san commented Nov 18, 2021

doesn't show in master. also super basic settings when running PR and Master
Untitled
r

@stenzek stenzek changed the title GS/OpenGL: Use framebuffer blits for CopyRectConv GS/OpenGL: Use shader+draw for CopyRectConv Nov 21, 2021
@ghost
Copy link

ghost commented Nov 21, 2021

This PR doesn't fix Spiderman 3 memleak on my end but probably unrelated then. Aside that, I didn't notice something wrong in particular.

@lightningterror
Copy link
Contributor

Would be nice to add these for more fps comparison graphs:

Big Mutha Truckers:
Master 53 fps
PR 77 fps

Sly 2:
Master 82 fps
PR 95 fps

Echo Night:
Master 20 fps
PR 37 fps

@JordanTheToaster
Copy link
Contributor

Tested with a fair selection of games and saw no issues haven't noticed any performance differences either.

@lightningterror
Copy link
Contributor

Tested with a fair selection of games and saw no issues haven't noticed any performance differences either.

Need to find games that use the effect to trigger.

@lightningterror lightningterror merged commit 78b74f1 into PCSX2:master Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Evolution Snowboarding - Extreme Slowdown
5 participants