Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDVD: Adjust DMA timing based on PS1 timings. #5056

Merged
merged 1 commit into from
Nov 22, 2021
Merged

Conversation

refractionpcsx2
Copy link
Member

@refractionpcsx2 refractionpcsx2 commented Nov 22, 2021

Description of Changes

Adjusts the CDVD DMA (3) timing to that based on PS1 tested numbers.

Rationale behind Changes

Bus width is 16bit on the PS2 between the DVD drive and the DSP, it is 8bit on PS1, so serves to reason the DMA would be twice the speed. (PS1 is 24 cycle per word)

Suggested Testing Steps

test games, make sure they still work and don't die horribly.

Fixes Spongebob Lights, Camera, Pants!

Bus width is 16bit on the PS2 and 8bit on PS1, so serves to reason the DMA would be twice the speed. (PS1 is 24 cycle per word)
@github-actions github-actions bot added the CDVD label Nov 22, 2021
@seta-san
Copy link
Contributor

seta-san commented Nov 22, 2021

totally fixes victorious boxers - no longer requires fast cdvd - no delay, music continues into second round
fixes bob the builder - no longer need fast cdvd
fixes spongebob light camera pants - gets past loading screen and now gets past the swap in the second minigame

shadowman didn't break.

didn't fix ecco the dolphin.

the other games in #4117 should be tested but i don't own.

@refractionpcsx2
Copy link
Member Author

refractionpcsx2 commented Nov 22, 2021

Will you stop going on about Ecco, that will never be fixed by anything :P
I thought bob the builder worked on master, same for victorious boxers?

@seta-san
Copy link
Contributor

nevermind. didn't know victorious boxer and bob the builder were already fixed. i thought they both still needed fast cdvd

@refractionpcsx2
Copy link
Member Author

Not that I know of. The main thing with this PR was fixing shit without breaking anything, which was being somewhat problematic, so I just went for something legitimate and it seemed to work well out of sheer luck I think lol

@refractionpcsx2 refractionpcsx2 added this to the Release 1.8 milestone Nov 22, 2021
@refractionpcsx2 refractionpcsx2 merged commit afacc47 into master Nov 22, 2021
@refractionpcsx2 refractionpcsx2 deleted the cdvd_slowerdma branch November 22, 2021 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants