GS: Unify HW texture caches#5087
Merged
Merged
Conversation
0ba8336 to
f397777
Compare
f397777 to
3704be1
Compare
3704be1 to
28bc854
Compare
It's used by the vs, why would you put it in the ps cb?
28bc854 to
54a9e48
Compare
Member
|
Tested with my selection of games on both DX11 and OpenGL and both functioned correctly with no issues I could observe. |
Member
|
Ran it through a bunch of gsdumps on DX and OGL, looks good to me :) |
refractionpcsx2
approved these changes
Dec 9, 2021
lightningterror
approved these changes
Dec 9, 2021
lightningterror
left a comment
Contributor
There was a problem hiding this comment.
Ran through some dumps, everything seemed fine.
| vec2 TC_OffsetHack; | ||
|
|
||
| vec3 pad1_cb21; | ||
| vec3 pad2_cb21; |
Contributor
There was a problem hiding this comment.
Hmm, we have 6 total free vectors, this can be optimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
intformatfield of textures, removing issues where e.g. no one outside ofGSDeviceOGLcould actually understand what the format of aGSTextureOGLmeant even though they could read it. Now anyone can ask aGSTexture*for its format and understand what it is.DownloadTextureand an optionalDownloadTextureConvertmethod toGSDevice, which downloads a texture and maps it to CPU memoryvirtualGSTextureCachemethods toGSTextureCacheand get rid of the separate subclasses per subclass ofGSDeviceps_convert##because it's impossible to figure out what's what when only looking at the list of shadersRationale behind Changes
Reduce per-renderer code so that adding a new renderer doesn't add as much maintenance cost
Suggested Testing Steps
Make sure renderers still work