Skip to content

Linux and Windows CMake Builds: Change output executable to lowercase#5100

Merged
refractionpcsx2 merged 1 commit intoPCSX2:masterfrom
F0bes:nix-lowercase-file
Dec 25, 2021
Merged

Linux and Windows CMake Builds: Change output executable to lowercase#5100
refractionpcsx2 merged 1 commit intoPCSX2:masterfrom
F0bes:nix-lowercase-file

Conversation

@F0bes
Copy link
Copy Markdown
Member

@F0bes F0bes commented Dec 4, 2021

Description of Changes

bin/PCSX2 is now bin/pcsx2 -- update your scripts!

Rationale behind Changes

Everything in Linux land is lowercase

Suggested Testing Steps

Build PCSX2 and see if it is lowercase

-- I believe I got everything covered for this change? PCSX2-Linux.sh still works

@F0bes F0bes force-pushed the nix-lowercase-file branch 2 times, most recently from 354bc2d to b3b166d Compare December 5, 2021 00:19
Copy link
Copy Markdown
Contributor

@Mrlinkwii Mrlinkwii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiles here , works as intended 👍

@F0bes F0bes force-pushed the nix-lowercase-file branch from b3b166d to 67fa3de Compare December 5, 2021 02:10
@qurious-pixel
Copy link
Copy Markdown
Contributor

I would expect it to fail to run from the desktop file.

Exec=env GDK_BACKEND=x11 MESA_NO_ERROR=1 PCSX2

Should the desktop file name, be lower-case?

@lightningterror
Copy link
Copy Markdown
Contributor

I prefer uppercase for PCSX2.

@F0bes
Copy link
Copy Markdown
Member Author

F0bes commented Dec 5, 2021

I would expect it to fail to run from the desktop file.

Exec=env GDK_BACKEND=x11 MESA_NO_ERROR=1 PCSX2

Should the desktop file name, be lower-case?

You're right

I prefer uppercase for PCSX2.

Why?

@lightningterror
Copy link
Copy Markdown
Contributor

lightningterror commented Dec 5, 2021

Why?

Seems more right since we use the upper case naming mostly everywhere.

edit: nvm, carry on, ref explained.

@refractionpcsx2
Copy link
Copy Markdown
Member

Sure, in the app and website it's fine since it's an acronym, but the filename should be lower case, especially on linux. Windows has always been lower case.

@F0bes F0bes changed the title LINUX / MAC Builds: Change output executable to lowercase LINUX Builds: Change output executable to lowercase Dec 5, 2021
@F0bes F0bes force-pushed the nix-lowercase-file branch from 67fa3de to 52ea307 Compare December 5, 2021 03:12
@fantesykikachu
Copy link
Copy Markdown

fantesykikachu commented Dec 5, 2021

Windows has always been lower case.

I just noticed that with the new cmake windows builds the executable filename as uppercase, maybe the PR should do lowercase executables everywhere.

@refractionpcsx2
Copy link
Copy Markdown
Member

Maybe it does, but only with CMake, the VS projects still output a lower case file.

@F0bes F0bes force-pushed the nix-lowercase-file branch from 52ea307 to c3cb80c Compare December 6, 2021 00:34
@F0bes F0bes changed the title LINUX Builds: Change output executable to lowercase Linux and Windows CMake Builds: Change output executable to lowercase Dec 6, 2021
@F0bes F0bes force-pushed the nix-lowercase-file branch 2 times, most recently from 6e5a85a to 0a986ee Compare December 6, 2021 01:04
Comment thread pcsx2/CMakeLists.txt Outdated
@F0bes F0bes force-pushed the nix-lowercase-file branch from 0a986ee to e2d0940 Compare December 6, 2021 02:03
@F0bes F0bes force-pushed the nix-lowercase-file branch from e2d0940 to 9dda58f Compare December 24, 2021 20:48
@F0bes
Copy link
Copy Markdown
Member Author

F0bes commented Dec 24, 2021

Rebased.

@refractionpcsx2 refractionpcsx2 merged commit 1695124 into PCSX2:master Dec 25, 2021
TingPing pushed a commit to flathub/net.pcsx2.PCSX2 that referenced this pull request Jan 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants