Linux and Windows CMake Builds: Change output executable to lowercase#5100
Linux and Windows CMake Builds: Change output executable to lowercase#5100refractionpcsx2 merged 1 commit intoPCSX2:masterfrom
Conversation
354bc2d to
b3b166d
Compare
Mrlinkwii
left a comment
There was a problem hiding this comment.
Compiles here , works as intended 👍
b3b166d to
67fa3de
Compare
|
I would expect it to fail to run from the desktop file.
Should the desktop file name, be lower-case? |
|
I prefer uppercase for PCSX2. |
You're right
Why? |
edit: nvm, carry on, ref explained. |
|
Sure, in the app and website it's fine since it's an acronym, but the filename should be lower case, especially on linux. Windows has always been lower case. |
67fa3de to
52ea307
Compare
I just noticed that with the new cmake windows builds the executable filename as uppercase, maybe the PR should do lowercase executables everywhere. |
|
Maybe it does, but only with CMake, the VS projects still output a lower case file. |
52ea307 to
c3cb80c
Compare
6e5a85a to
0a986ee
Compare
0a986ee to
e2d0940
Compare
No reason to be uppercase.
e2d0940 to
9dda58f
Compare
|
Rebased. |
Change introduced upstream in PCSX2/pcsx2#5100.
Description of Changes
bin/PCSX2 is now bin/pcsx2 -- update your scripts!
Rationale behind Changes
Everything in Linux land is lowercase
Suggested Testing Steps
Build PCSX2 and see if it is lowercase
-- I believe I got everything covered for this change? PCSX2-Linux.sh still works