GS: Check CLUT dirty write on vertex kick - #5154
Merged
Merged
Conversation
Mrlinkwii
approved these changes
Dec 13, 2021
refractionpcsx2
force-pushed
the
gs_dirtyclut
branch
from
December 14, 2021 07:53
7e33388 to
6d2f5c5
Compare
refractionpcsx2
changed the title
CLUT only updates if valid index type used in PSM
lightningterror
approved these changes
Dec 14, 2021
Mrlinkwii
approved these changes
Dec 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Check CLUT dirty write on vertex kick instead of during the actual draws.
Rationale behind Changes
Previously the CLUT dirty check was done during the draw, however this is way too late and we're not actually invalidating memory at this point, just marking the CLUT as dirty, it will then flush the draws THEN invalidate the CLUT, meaning it is in the correct state for the upcoming draws. Virtual On was modifying the CLUT in quick succession causing it to end up with an invalid version of the CLUT.
Suggested Testing Steps
Test games with colour issues in the software renderer (Hardware maybe too, but that has other problems, especially with the Sega games). General games worth testing too, just to make sure I didn't bust anything.
Fixes #4826