-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GameDB: add VU clamping to "Ultimate Spider-Man" and fixes to other games #5187
Conversation
I have 2 more request while we have a PR open for that. Can you please also add the vu clamping to the pal version of Ridge Racer V as well as the gif fifo hack to Fight Night Round 3? |
@gilderoylockhart01 which VU clamping dose Ridge Racer V need also what dose it fix ? |
Ridge racer needs VU clamping to extra. That fixes the woman's cloth rendering in the intro. If you need info for fight night round 3, just copy past the one from fifa street 2. |
I actually checked the gamedb and for some reasons, none of the ridge racer V entries have the clamping fix, can you expend the pal gamefix to the other regions as well? |
For Klonoa 2, I want to know if the DMA busy or VU1 sync gamefixes does something about this. |
@@ -7880,15 +7891,14 @@ SLES-50267: | |||
2547FF67: | |||
content: |- | |||
author=Nachbrenner | |||
// Skip PSX2_Mpeg_PlayFile__FPc. | |||
patch=0,EE,00107a00,word,03e00008 | |||
patch=0,EE,00107a04,word,24020001 | |||
// Skip SuperSync__Fi. | |||
patch=0,EE,00100eb0,word,03e00008 | |||
patch=0,EE,00100eb4,word,24020001 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to check that game on the current IPU PR to see if we can get rid of the whole patch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It still needs it, it's not an IPU bug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What kind of bug is it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The game finishes a bunch of DMA's, then sets the PCR register to check VIF1, GIF and SIF1 to check for them being finished, then loops doing BC0F, which means it waits until all the DMA's have finished. All of them but GIF show as finished, because the game earlier cleared the fact the GIF had finished. So it could be GIF is too fast? I dunno...
bin/resources/GameIndex.yaml
Outdated
@@ -36386,6 +36428,8 @@ SLUS-20870: | |||
name: "Ultimate Spider-Man" | |||
region: "NTSC-U" | |||
compat: 5 | |||
clampModes: | |||
vuClampMode: 0 # Fixes wrong texture colour |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra space after fixes and texture, also period at the end please.
bin/resources/GameIndex.yaml
Outdated
@@ -38197,7 +38241,7 @@ SLUS-21264: | |||
region: "NTSC-U" | |||
compat: 5 | |||
clampModes: | |||
vuClampMode: 2 # Fix black textures on characters. | |||
vuClampMode: 3 # Fix black textures on characters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra space before the hash
bin/resources/GameIndex.yaml
Outdated
@@ -38770,6 +38816,8 @@ SLUS-21383: | |||
name: "Fight Night - Round 3" | |||
region: "NTSC-U" | |||
compat: 5 | |||
gameFixes: | |||
- GIFFIFOHack # Fixes flag corruptions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
corruption, not corruptions
bin/resources/GameIndex.yaml
Outdated
gameFixes: | ||
- EETimingHack # Fixes flickering graphics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer gameFixes under clamping, if you can.
bin/resources/GameIndex.yaml
Outdated
name: "Ultimate Spider-Man" | ||
region: "NTSC-J" | ||
clampModes: | ||
vuClampMode: 0 # Fixes spiderman eye texture colour. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spider-Man's
bin/resources/GameIndex.yaml
Outdated
@@ -25422,7 +25452,7 @@ SLPM-66191: | |||
name: "Tiger Woods PGA Tour 06" | |||
region: "NTSC-J" | |||
clampModes: | |||
vuClampMode: 2 # Fixes black textures on characters. | |||
vuClampMode: 3 # Fixes black textures on characters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extras space before the hash
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Space before # is still an issue.
bin/resources/GameIndex.yaml
Outdated
@@ -14226,7 +14240,7 @@ SLES-53541: | |||
name: "Tiger Woods PGA Tour 06" | |||
region: "PAL-M4" | |||
clampModes: | |||
vuClampMode: 2 # Fix black textures on characters. | |||
vuClampMode: 3 # Fix black textures on characters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra space before hash
bin/resources/GameIndex.yaml
Outdated
SLES-53391: | ||
name: "Ultimate Spider-Man" | ||
region: "PAL-M5" | ||
clampModes: | ||
vuClampMode: 0 # Fixes spiderman eye texture colour. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spider-Man's
bin/resources/GameIndex.yaml
Outdated
@@ -13793,9 +13803,13 @@ SLES-53390: | |||
name: "Ultimate Spider-Man" | |||
region: "PAL-E" | |||
compat: 5 | |||
clampModes: | |||
vuClampMode: 0 # Fixes spiderman eye texture colour. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spider-Man's
bin/resources/GameIndex.yaml
Outdated
@@ -14515,6 +14529,8 @@ SLES-53668: | |||
SLES-53672: | |||
name: "Ultimate Spider-Man [Limited]" | |||
region: "PAL-E" | |||
clampModes: | |||
vuClampMode: 0 # Fixes Fixes spiderman eye texture colour. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spider-Man's
bin/resources/GameIndex.yaml
Outdated
@@ -38295,6 +38338,8 @@ SLUS-21284: | |||
SLUS-21285: | |||
name: "Ultimate Spider-Man [Limited Edition]" | |||
region: "NTSC-U" | |||
clampModes: | |||
vuClampMode: 0 # Fixes spidermans eyes texture. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spider-Man's
bin/resources/GameIndex.yaml
Outdated
@@ -25422,7 +25452,7 @@ SLPM-66191: | |||
name: "Tiger Woods PGA Tour 06" | |||
region: "NTSC-J" | |||
clampModes: | |||
vuClampMode: 2 # Fixes black textures on characters. | |||
vuClampMode: 3 # Fixes black textures on characters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Space before # is still an issue.
Description of Changes
add VU clamping to "Ultimate Spider-Man" , adds fixes for Ridge Racer V , EyeToy - Bob the Builder , Klonoa 2 , Fight Night and remove parts of patches adds a patch for Super Shanghai 2005
Rationale behind Changes
Fixes: #5186
Fixes: #5122
Suggested Testing Steps