Skip to content

GameDB: add VU clamping to "Ultimate Spider-Man" and fixes to other games#5187

Merged
refractionpcsx2 merged 1 commit into
PCSX2:masterfrom
Mrlinkwii:spiderman-can-
Dec 27, 2021
Merged

GameDB: add VU clamping to "Ultimate Spider-Man" and fixes to other games#5187
refractionpcsx2 merged 1 commit into
PCSX2:masterfrom
Mrlinkwii:spiderman-can-

Conversation

@Mrlinkwii

@Mrlinkwii Mrlinkwii commented Dec 19, 2021

Copy link
Copy Markdown
Contributor

Description of Changes

add VU clamping to "Ultimate Spider-Man" , adds fixes for Ridge Racer V , EyeToy - Bob the Builder , Klonoa 2 , Fight Night and remove parts of patches adds a patch for Super Shanghai 2005

Rationale behind Changes

Fixes: #5186
Fixes: #5122

Suggested Testing Steps

@ghost

ghost commented Dec 19, 2021

Copy link
Copy Markdown

I have 2 more request while we have a PR open for that.

Can you please also add the vu clamping to the pal version of Ridge Racer V as well as the gif fifo hack to Fight Night Round 3?

@Mrlinkwii

Copy link
Copy Markdown
Contributor Author

@gilderoylockhart01 which VU clamping dose Ridge Racer V need also what dose it fix ?

@ghost

ghost commented Dec 19, 2021

Copy link
Copy Markdown

Ridge racer needs VU clamping to extra. That fixes the woman's cloth rendering in the intro.

If you need info for fight night round 3, just copy past the one from fifa street 2.

@Mrlinkwii Mrlinkwii changed the title GameDB: add VU clamping to "Ultimate Spider-Man" GameDB: add VU clamping to "Ultimate Spider-Man" and fixes to other games Dec 19, 2021
@ghost

ghost commented Dec 20, 2021

Copy link
Copy Markdown

I actually checked the gamedb and for some reasons, none of the ridge racer V entries have the clamping fix, can you expend the pal gamefix to the other regions as well?

@ghost

ghost commented Dec 23, 2021

Copy link
Copy Markdown

For Klonoa 2, I want to know if the DMA busy or VU1 sync gamefixes does something about this.

patch=0,EE,00107a04,word,24020001
// Skip SuperSync__Fi.
patch=0,EE,00100eb0,word,03e00008
patch=0,EE,00100eb4,word,24020001

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to check that game on the current IPU PR to see if we can get rid of the whole patch.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It still needs it, it's not an IPU bug.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What kind of bug is it?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The game finishes a bunch of DMA's, then sets the PCR register to check VIF1, GIF and SIF1 to check for them being finished, then loops doing BC0F, which means it waits until all the DMA's have finished. All of them but GIF show as finished, because the game earlier cleared the fact the GIF had finished. So it could be GIF is too fast? I dunno...

Comment thread bin/resources/GameIndex.yaml Outdated
region: "NTSC-U"
compat: 5
clampModes:
vuClampMode: 0 # Fixes wrong texture colour

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra space after fixes and texture, also period at the end please.

Comment thread bin/resources/GameIndex.yaml Outdated
compat: 5
clampModes:
vuClampMode: 2 # Fix black textures on characters.
vuClampMode: 3 # Fix black textures on characters.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra space before the hash

Comment thread bin/resources/GameIndex.yaml Outdated
region: "NTSC-U"
compat: 5
gameFixes:
- GIFFIFOHack # Fixes flag corruptions.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corruption, not corruptions

Comment thread bin/resources/GameIndex.yaml Outdated
Comment on lines +41134 to +41135
gameFixes:
- EETimingHack # Fixes flickering graphics.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer gameFixes under clamping, if you can.

Comment thread bin/resources/GameIndex.yaml Outdated
name: "Ultimate Spider-Man"
region: "NTSC-J"
clampModes:
vuClampMode: 0 # Fixes spiderman eye texture colour.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spider-Man's

Comment thread bin/resources/GameIndex.yaml Outdated
region: "NTSC-J"
clampModes:
vuClampMode: 2 # Fixes black textures on characters.
vuClampMode: 3 # Fixes black textures on characters.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extras space before the hash

@refractionpcsx2 refractionpcsx2 Dec 27, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space before # is still an issue.

Comment thread bin/resources/GameIndex.yaml Outdated
region: "PAL-M4"
clampModes:
vuClampMode: 2 # Fix black textures on characters.
vuClampMode: 3 # Fix black textures on characters.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra space before hash

Comment thread bin/resources/GameIndex.yaml Outdated
name: "Ultimate Spider-Man"
region: "PAL-M5"
clampModes:
vuClampMode: 0 # Fixes spiderman eye texture colour.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spider-Man's

Comment thread bin/resources/GameIndex.yaml Outdated
region: "PAL-E"
compat: 5
clampModes:
vuClampMode: 0 # Fixes spiderman eye texture colour.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spider-Man's

Comment thread bin/resources/GameIndex.yaml Outdated
name: "Ultimate Spider-Man [Limited]"
region: "PAL-E"
clampModes:
vuClampMode: 0 # Fixes Fixes spiderman eye texture colour.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spider-Man's

Comment thread bin/resources/GameIndex.yaml Outdated
name: "Ultimate Spider-Man [Limited Edition]"
region: "NTSC-U"
clampModes:
vuClampMode: 0 # Fixes spidermans eyes texture.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spider-Man's

Comment thread bin/resources/GameIndex.yaml Outdated
region: "NTSC-J"
clampModes:
vuClampMode: 2 # Fixes black textures on characters.
vuClampMode: 3 # Fixes black textures on characters.

@refractionpcsx2 refractionpcsx2 Dec 27, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space before # is still an issue.

@refractionpcsx2 refractionpcsx2 merged commit 1aad3e6 into PCSX2:master Dec 27, 2021
@Mrlinkwii Mrlinkwii deleted the spiderman-can- branch December 27, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

2 participants