Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GS: Move afix check to high blend level #5196

Merged
merged 1 commit into from
Dec 28, 2021

Conversation

TellowKrinkle
Copy link
Member

Description of Changes

Move SW blending check of AFIX > 128 to High blend mode
Fixes #5193

Rationale behind Changes

Vertex trace check can have false positives but afix check cannot, so it makes sense to separate them

Suggested Testing Steps

Check games on OpenGL with SW blending set to High. Compare graphics to Full and performance to previous High.

@nobleflame
Copy link

nobleflame commented Dec 26, 2021

Hey, could you base this on the latest master so I can play around with it for a bit?
I want to do a complete play through of MGS2 to check for frame drops and since the scan mask fix is now in the latest dev build I thought it would be a good time to test high blending accuracy.

Cheers!

edit: thanks :)

@TellowKrinkle TellowKrinkle merged commit 61a196b into PCSX2:master Dec 28, 2021
@TellowKrinkle TellowKrinkle deleted the blend-high-afix branch December 28, 2021 02:18
@nobleflame
Copy link

Hi tellowkrinkle, I've continued to test the high blending accuracy with MGS2 and am getting slow speeds in some specific areas (notably areas with lots of small interactable objects). I have all settings on default and tend to lose up to 15% speed at upscaled 1080p.

I'm guessing not much can be done about this unless the afix check can be moved down lower in the blending options. Anyway, I'm just letting you know as I said I'd test this further.

Thanks for all of your work on this. It certainly does work in terms of accurate effects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: MGS2 skin textures and blending accuracy
2 participants