GS-hw: Fix recent alpha max check.#5197
Merged
Merged
Conversation
Member
|
Instead of this mess where we try to do all sorts of checks to only run Then we won't accidentally mess up conditions and we won't have to worry about that anymore at all |
Member
|
Side note, GetAlphaMinMax() already checks private:
void CalcAlphaMinMax();
public:
GSVertexTrace::VertexAlpha& GetAlphaMinMax()
{
if (!m_vt.m_alpha.valid)
CalcAlphaMinMax();
return m_vt.m_alpha;
} |
Cleaner this way, also fix recent regression on Full Blend with alpha max.
lightningterror
force-pushed
the
more-alpha-checks
branch
from
December 21, 2021 01:38
fad514a to
0b9c53b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
GS: Redo GetAlphaMinMax.
Cleaner this way, also fix recent regression on Full Blend with alpha max.
GS-hw: Move the blend mix alpha check after sw blending selection.
Optimization.
Rationale behind Changes
Fix recent regression and optimization.
Suggested Testing Steps
Test blending and make sure still works on both renderers.