GS-hw: Extend Blend mix to work when alpha is higher than 1.#5213
Merged
Conversation
lightningterror
force-pushed
the
blend-mix-alpha-clamp
branch
from
5f38847 to
0ffe7b8
Compare
lightningterror
changed the title
Clamp the alpha(As/Af) to 1 in the shader, it is already clamped to 1 in hw blend unit. It should allow to better render the effects, still not fully accurate but it's closer to what we want. Hopefully it helps D3D11 more.
lightningterror
force-pushed
the
blend-mix-alpha-clamp
branch
from
0ffe7b8 to
863c797
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Clamp the alpha(As/Af) to 1 in the shader, it is already clamped to 1 in hw blend unit.
It should allow to better render the effects, still not fully accurate but it's closer to what we want.
Hopefully it helps D3D11 more.
Rationale behind Changes
Accuracy.
Suggested Testing Steps
Both renderers are affected, however more noticeable on D3D11, test Blending with higher focus on D3D11.