GSDumpDialog: Cache length instead of querying every packet#5220
Merged
refractionpcsx2 merged 1 commit intoPCSX2:masterfrom Dec 28, 2021
stenzek:gsdump-length
Merged
GSDumpDialog: Cache length instead of querying every packet#5220refractionpcsx2 merged 1 commit intoPCSX2:masterfrom stenzek:gsdump-length
refractionpcsx2 merged 1 commit intoPCSX2:masterfrom
stenzek:gsdump-length
Conversation
Length() internally calls fseek() to end, ftell(), and fseek() back again (really slow). Shaves several seconds off loading large gs dumps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Length() internally calls fseek() to end, ftell(), and fseek() back again (really slow).
Shaves several seconds off loading large gs dumps.