Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memcard: Detect and attempt to repair broken index files from the v1.7.2115 bug #5751

Merged

Conversation

xTVaser
Copy link
Sponsor Member

@xTVaser xTVaser commented Mar 24, 2022

Description of Changes

The current folder memory card implementation appears to still be working as intended after the aforementioned fix #5356 but some people have been obviously caught by it. The folder memory card code is currently being re-written, so it doesn't make sense to go too crazy with re-writing.

If the index file is detected as malformed, it backs it up and re-creates it by scanning the directory. For most games, (i've tested with a few), this brings things back to a working state with no data loss.

Rationale behind Changes

Only the index file is broken because of the aforementioned bug, which only matters for very specific games that depend on the order of the files (ie. GTA).

Suggested Testing Steps

  • Do not merge this too fast....let's let it sit for a while and be tested by people that ran into the problem.
  • Intentionally break your _pcsx2_index file, you should see an error in the console when booting games and it should patch things up -- see if you can load your save files as expected
  • Do significant folder memory card testing as well, load and save multiple times. Last thing I'd want is to create another bug trying to remedy an old one....
  • Involve unicode in your memory card path and in the file names that are restored

@refractionpcsx2 refractionpcsx2 merged commit 2951068 into PCSX2:master Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants