Qt: Add DS4/DS5 LED settings #7894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stenzek
force-pushed
the
led
branch
2 times, most recently
from
7efe51e
to
a9255a6
Compare
JordanTheToaster
approved these changes
Jan 15, 2023
RedDevilus
reviewed
Jan 15, 2023
There was a problem hiding this comment.
When I enable the new mode, change to other colors or not but then press Cancel, it will give a black color instead (probably defaulting to first color of the basic colors and not remembering the default or changed colors. It's resetting instead of not changing previous value.
1:
2:
3:
Otherwise seems fine.
|
Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This PR lets you set a custom LED colour for the first four players' controllers, via SDL.
Rationale behind Changes
It's neat. Also helps identifying which controller is which.
Suggested Testing Steps
Test changing LED colours with DS4 or DS5.