From 6d52a3b9bb4701c275fb11437c6b88329924feac Mon Sep 17 00:00:00 2001 From: Andrew Bell Date: Thu, 19 Mar 2020 11:14:27 -0400 Subject: [PATCH] Don't access invalid memory. (#2986) * Don't access invalid memory. * Remove unnecessary cast. --- pdal/util/Utils.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pdal/util/Utils.cpp b/pdal/util/Utils.cpp index 438b6bfb45..1012927ce1 100644 --- a/pdal/util/Utils.cpp +++ b/pdal/util/Utils.cpp @@ -436,8 +436,8 @@ std::string Utils::escapeJSON(const std::string &str) }; for (std::string::size_type i = 0; i < s.size();) { - char val = s[i]; - if (val < (char)replacements.size()) + unsigned char val = s[i]; + if (val < replacements.size()) { s.replace(i, 1, replacements[val]); i += replacements[val].size();