From 86d319214dbbaea8af971b03b43e71c2eb4824f9 Mon Sep 17 00:00:00 2001
From: Andrew Bell <andrew.bell.ia@gmail.com>
Date: Fri, 10 May 2019 08:51:54 -0400
Subject: [PATCH] Don't assign PointId's to size_t in test. (32 bit systems
 have 32 bit size_t). Close #2509

---
 pdal/Mesh.hpp                            | 12 +++++++
 test/unit/filters/DelaunayFilterTest.cpp | 46 ++++++------------------
 2 files changed, 23 insertions(+), 35 deletions(-)

diff --git a/pdal/Mesh.hpp b/pdal/Mesh.hpp
index f7c6fa948d..ca1afa6c22 100644
--- a/pdal/Mesh.hpp
+++ b/pdal/Mesh.hpp
@@ -34,6 +34,7 @@
 
 #pragma once
 
+#include <array>
 #include <deque>
 
 namespace pdal
@@ -48,8 +49,19 @@ class PDAL_DLL Triangle
     PointId m_a;
     PointId m_b;
     PointId m_c;
+
+    friend bool operator == (const Triangle& a, const Triangle& b);
 };
 
+inline bool operator == (const Triangle& a, const Triangle& b)
+{
+    std::array<PointId, 3> aa {a.m_a, a.m_b, a.m_c};
+    std::array<PointId, 3> bb {b.m_a, b.m_b, b.m_c};
+    std::sort(aa.begin(), aa.end());
+    std::sort(bb.begin(), bb.end());
+    return aa == bb;
+}
+
 /**
   A mesh is a way to represent a set of points connected by edges.  Point
   indices are into a point view.
diff --git a/test/unit/filters/DelaunayFilterTest.cpp b/test/unit/filters/DelaunayFilterTest.cpp
index be8fe6cd68..34fe0730bd 100644
--- a/test/unit/filters/DelaunayFilterTest.cpp
+++ b/test/unit/filters/DelaunayFilterTest.cpp
@@ -52,7 +52,7 @@ TEST(DelaunayFilterTest, test1)
     // input file. For each of these triangles, we will check for all
     // index permutations, as long as the vertices appear in
     // counterclockwise order.
-    std::vector<std::vector<size_t>> expectedTriangles = 
+    std::vector<Triangle> expectedTriangles =
     {
         {5, 2, 0},
         {2, 5, 4},
@@ -60,11 +60,11 @@ TEST(DelaunayFilterTest, test1)
         {2, 1, 0},
         {3, 1, 2}
     };
-    
+
     // Number of detected occurrences of each of the expected triangles.
     // Initialize to zeros.
     std::vector<int> expectedTrianglesOccurrences(expectedTriangles.size(), 0);
-    
+
     Options readerOps;
     readerOps.add("filename",
         Support::datapath("filters/delaunaytest.txt"));
@@ -84,42 +84,18 @@ TEST(DelaunayFilterTest, test1)
     EXPECT_EQ(view->size(), 6u);
     TriangularMesh *mesh = view->mesh("delaunay2d");
     EXPECT_EQ(mesh->size(), expectedTriangles.size());
-    
+
     // Loop through the triangles of the generated mesh...
     for (size_t i = 0; i < mesh->size(); i++)
     {
         Triangle triangle = (*mesh)[i];
-        
-        // Build a vector so we can compare to an expected triangle with
-        // the == operator.
-        std::vector<size_t> triangleVector = {triangle.m_a, triangle.m_b, triangle.m_c};
-        
-        // Go through all of the expected triangles to check for a
-        // match.
-        for (size_t i = 0; i < expectedTriangles.size(); i++)
-        {
-            std::vector<size_t> expectedTriangle = expectedTriangles[i];
-            
-            // Go through all counterclockwise vertex permutations for
-            // this expected triangle.
-            for (std::vector<size_t>::iterator iter = expectedTriangle.begin(); iter != expectedTriangle.end(); iter++)
-            {
-                std::vector<size_t> expectedTrianglePermutation = {0, 0, 0};
-                std::rotate_copy(expectedTriangle.begin(), iter, expectedTriangle.end(), expectedTrianglePermutation.begin());
-                
-                if (triangleVector == expectedTrianglePermutation)
-                {
-                    // We have a match!
-                    expectedTrianglesOccurrences[i] += 1;
-                }
-            }
-        }
-    }
-    
-    // Assert that each of the expected triangles occurred exactly once.
-    for (int triangleOccurrences : expectedTrianglesOccurrences)
-    {
-        EXPECT_EQ(triangleOccurrences, 1);
+
+        auto it = std::find(expectedTriangles.begin(), expectedTriangles.end(),
+            triangle);
+        bool found = (it != expectedTriangles.end());
+        EXPECT_TRUE(found);
+        expectedTriangles.erase(it);
     }
+    EXPECT_EQ(expectedTriangles.size(), (size_t)0);
 }