From ed8ab9fef9056f60fe66645c43afe03fb2d81ed0 Mon Sep 17 00:00:00 2001
From: Andrew Bell <andrew.bell.ia@gmail.com>
Date: Tue, 9 Feb 2021 13:00:10 -0500
Subject: [PATCH] Return an error code if no command is provided. Close #3354

---
 apps/pdal.cpp | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/apps/pdal.cpp b/apps/pdal.cpp
index 454dd6032d..a7edf2e897 100644
--- a/apps/pdal.cpp
+++ b/apps/pdal.cpp
@@ -323,7 +323,7 @@ int App::execute(StringList& cmdArgs, LogPtr& log)
     catch (arg_val_error const& e)
     {
         Utils::printError(e.what());
-        return -1;
+        return 1;
     }
 
     log = Log::makeLog("PDAL", m_log, m_logtiming);
@@ -371,8 +371,11 @@ int App::execute(StringList& cmdArgs, LogPtr& log)
             gdal::unregisterDrivers();
         }
         else
+        {
             log->get(LogLevel::Error) << "Command '" << m_command <<
                 "' not recognized" << std::endl << std::endl;
+            ret = 1;
+        }
         return ret;
     }
 
@@ -381,7 +384,7 @@ int App::execute(StringList& cmdArgs, LogPtr& log)
     if (cmdArgs.size())
     {
         Utils::printError("Unexpected argument '" + cmdArgs[0] + "'.");
-        return -1;
+        return 1;
     }
 
     if (m_showVersion)