Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create raster based on face interpolation. #3161

Merged
merged 7 commits into from Jul 10, 2020
Merged

Create raster based on face interpolation. #3161

merged 7 commits into from Jul 10, 2020

Conversation

abellgithub
Copy link
Contributor

No description provided.

@abellgithub abellgithub requested a review from chambbj July 8, 2020 12:42
Copy link
Member

@chambbj chambbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few single line comments; nothing too major. Overall looking very nice and I can imagine some other places where this could be used!

filters/FaceRasterFilter.cpp Outdated Show resolved Hide resolved
/// \param x3, y3, z3 Coordinates of point 3.
/// \param x, y X and Y coordinates of location to find an interpolated Z
/// \return Interpolated Z value or infinity.
double barycentricInterpolation(double x1, double y1, double z1,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing you didn't change anything when moving to MathUtils (good call doing so BTW). We don't have any tests for this though. Would probably be a good thing to add going forward.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are tests in hag that exercise this. I could extract, I think.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pdal/private/Raster.hpp Show resolved Hide resolved
Arg *m_heightArg;
};

// This is a raw raster suitable for sticking into GDAL. X goes right to left, Y goes from
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right to left? This always trips me up, but I thought Y was the axis that typically gets flipped when not careful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops.

pdal/private/MathUtils.hpp Show resolved Hide resolved
pdal/PointView.hpp Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants