New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create raster based on face interpolation. #3161
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few single line comments; nothing too major. Overall looking very nice and I can imagine some other places where this could be used!
/// \param x3, y3, z3 Coordinates of point 3. | ||
/// \param x, y X and Y coordinates of location to find an interpolated Z | ||
/// \return Interpolated Z value or infinity. | ||
double barycentricInterpolation(double x1, double y1, double z1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing you didn't change anything when moving to MathUtils (good call doing so BTW). We don't have any tests for this though. Would probably be a good thing to add going forward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are tests in hag that exercise this. I could extract, I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, I suppose by proxy via https://github.com/PDAL/PDAL/blob/master/test/unit/filters/HAGFilterTest.cpp#L47.
Arg *m_heightArg; | ||
}; | ||
|
||
// This is a raw raster suitable for sticking into GDAL. X goes right to left, Y goes from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right to left? This always trips me up, but I thought Y was the axis that typically gets flipped when not careful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops.
No description provided.