New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test messages #18

Merged
merged 4 commits into from Sep 27, 2015

Conversation

Projects
None yet
2 participants
@kaoru
Contributor

kaoru commented Sep 26, 2015

One of my pet peeves is tests with no messages. I saw you had even put some comments in the test files such as

#1-10

Having unique test messages for every test makes that sort of thing unnecessary :-)

I also learned a lot about what possible things PDL::Stats can do so it was a good time for me even if you don't merge this. I'm sure I've written PDL::Stats::TS::fill_ma before when I should've just reached for PDL.

kaoru added some commits Sep 26, 2015

Add test messages to all tests in stats_basic.t
Would have liked to have documented the different outputs of the t_test
functions by more than just their variable names, but I couldn't find
any documentation on what they actually are.

maggiexyz added a commit that referenced this pull request Sep 27, 2015

@maggiexyz maggiexyz merged commit eebe720 into PDLPorters:master Sep 27, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 74.951%
Details
@maggiexyz

This comment has been minimized.

Show comment
Hide comment
@maggiexyz

maggiexyz Sep 27, 2015

Contributor

Much appreciated!

Contributor

maggiexyz commented Sep 27, 2015

Much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment