Skip to content
Browse files

Merge branch 'master' into 64bit-index-support

  • Loading branch information...
2 parents ea4224c + 26021f0 commit b7ab80b580e96cb5ed95dce27691aafecdcd397f @devel-chm devel-chm committed
Showing with 231 additions and 90 deletions.
  1. +1 −1 Basic/PDL.pm
  2. +10 −1 Basic/Pod/MATLAB.pod
  3. +2 −2 DEPENDENCIES
  4. +30 −28 Graphics/Limits/Limits.pm
  5. +18 −0 INSTALL
  6. +26 −29 Known_problems
  7. +1 −1 MANIFEST
  8. +4 −1 Perldl2/Profile/Perldl2.pm
  9. +5 −1 Perldl2/pdl2
  10. +107 −2 Release_Notes
  11. +1 −1 t/flexraw.t
  12. +21 −19 t/flexraw_fortran.t
  13. +2 −1 t/limits_round.t
  14. +3 −3 t/limits_trans_err.t
View
2 Basic/PDL.pm
@@ -146,7 +146,7 @@ start-up modules.
# set the version:
-$PDL::VERSION = '2.4.10_005'; # Go to sub numbering per git push
+$PDL::VERSION = '2.4.11_001'; # Go to sub numbering per git push
# Main loader of standard PDL package
View
11 Basic/Pod/MATLAB.pod
@@ -522,7 +522,7 @@ For that, use I<piddles>:
$pdl = ones 600, 600;
For example:
-
+
$points = pdl 1..10_000_000 # 4.7 seconds
$points = sequence 10_000_000 # milliseconds
@@ -658,6 +658,15 @@ So, in the previous examples:
=head1 ADDITIONAL FEATURES
+=head2 ASCII File IO
+
+To read data files containing whitespace separated columns of
+numbers (as would be read using the MATLAB I<load> command)
+one uses the PDL I<rcols> in L<PDL::IO::Misc>. For a general
+review of the IO functionality available in PDL, see the
+documentation for L<PDL::IO>, e.g., C<help PDL::IO> in the I<pdl2>
+shell or C< pdldoc PDL::IO > from the shell command line.
+
=head2 Data structures
To create complex data structures, MATLAB uses "I<cell arrays>" and
View
4 DEPENDENCIES
@@ -52,8 +52,8 @@ PDL::NiceSlice Text::Balanced >= 1.89 A nicer way to index piddles.
Inline::Pdlpp Inline >= 0.43 This module allows to define fast
PP code inline in your scripts.
- NOTE: Inline is listed as as PDL
- prerequisite for CPAN, you can
+ NOTE: Though Inline is listed as as
+ PDL prerequisite for CPAN, you can
build PDL manually without it.
View
58 Graphics/Limits/Limits.pm
@@ -14,7 +14,7 @@ our %EXPORT_TAGS = ( 'all' => [ qw(
our @EXPORT_OK = ( @{ $EXPORT_TAGS{'all'} } );
our @EXPORT = qw(
- limits
+ limits
);
our $VERSION = '0.01';
@@ -40,12 +40,12 @@ sub set_mask
{
my ( $mask, $data ) = @_;
- if ( $PDL::Bad::Status )
+ if ( $PDL::Bad::Status )
{
my $badflag = $data->badflag();
$data->badflag(1);
- $mask .= $PDL::Bad::UseNaN ? (! $data->isbad ) : ( $data->isfinite & ! $data->isbad );
+ $mask .= $PDL::Bad::UseNaN ? (! $data->isbad ) : ( $data->isfinite & ! $data->isbad );
$data->badflag($badflag);
} else
@@ -105,8 +105,8 @@ sub set_mask
"inconsistent number of elements",
"expected $n, got ", $vec->{$_}->nelem, "\n" )
foreach
- grep { exists $vec->{$_} &&
- defined $vec->{$_} &&
+ grep { exists $vec->{$_} &&
+ defined $vec->{$_} &&
$vec->{$_}->nelem != $n }
qw( data en ep );
}
@@ -267,9 +267,9 @@ sub round_pow
$what = $flip{$what} if $x < 0 ;
- $ilog--
+ $ilog--
if ( $xlog <= 0 && ( 'down' eq $what || $xlog != $ilog ) )
- ||
+ ||
( $xlog > 0 && 'down' eq $what && $xlog == $ilog ) ;
my $pwr = 10 ** $ilog;
@@ -282,6 +282,8 @@ sub round_pow
$i = 2 if $frac < $nice[2];
$i = 1 if $frac < $nice[1];
$i = 0 if $frac < $nice[0];
+ my $t = ( $x < 0 ? -1 : 1 ) * $pwr * $nice[$i];
+ if(abs($t - $x) < 0.0000001) {$i++}
}
elsif ( 'down' eq $what )
@@ -329,7 +331,7 @@ sub setup_multi
# normalize_dsets
#
# transform the user's heterogeneous list of data sets into a regular
-# list of data sets, each with the form
+# list of data sets, each with the form
# { Vectors => \@vectors }
# where each vector is a hashref with the following keys:
# { data => $data,
@@ -355,8 +357,8 @@ sub normalize_dsets
# scalar or piddle, turn it into its own data set
if ( ! $ref || UNIVERSAL::isa($ds, 'PDL') )
{
- push @dsets,
- PDL::Graphics::Limits::DSet->new( $attr->{Min}, $attr->{Max},
+ push @dsets,
+ PDL::Graphics::Limits::DSet->new( $attr->{Min}, $attr->{Max},
{ data => PDL::Core::topdl( $ds ) } );
}
@@ -404,7 +406,7 @@ sub normalize_dsets
# array refs in data set lists may be just a plain ol' data set, or
# it may contain a bunch of other stuff. here we deal with a single
-# array ref. we tear it apart and (re)build data sets.
+# array ref. we tear it apart and (re)build data sets.
sub normalize_array
{
my ( $dsets, $attr, $aref ) = @_;
@@ -459,15 +461,15 @@ sub normalize_array
for my $vec ( @$aref )
{
my $ref = ref $vec;
-
+
eval
{
# naked scalar or piddle: data vector with no attributes
if ( ! $ref || UNIVERSAL::isa($vec, 'PDL') )
{
- push @vecs, { data => PDL::Core::topdl( $vec ) };
+ push @vecs, { data => PDL::Core::topdl( $vec ) };
}
-
+
# array: data vector with attributes
elsif ( 'ARRAY' eq $ref )
{
@@ -486,8 +488,8 @@ sub normalize_array
die( 'vector ', @vecs+1, ": $@\n" );
}
}
-
- push @$dsets,
+
+ push @$dsets,
PDL::Graphics::Limits::DSet->new( $attr->{Min}, $attr->{Max}, @vecs )
if @vecs;
}
@@ -507,7 +509,7 @@ sub normalize_array_vec
{
my ( $vec ) = @_;
- # we should have
+ # we should have
# [ $data, [ $err | $err_n, $err_p ], [ \&func ] ]
my @el = @$vec;
@@ -553,7 +555,7 @@ sub normalize_array_vec
#####################################################################
# this takes a hash and a hash key spec and generates a regularized
-# data set array of the form
+# data set array of the form
# [ { data => $data, ep => ..., en => ..., trans => }, ... ]
sub normalize_hash_dset
{
@@ -879,7 +881,7 @@ sub limits
VecKeys => [],
KeyCroak => 1,
Limits => [],
- Trans => [],
+ Trans => [],
}, $attr );
# turn Trans and VecKeys into arrays if necessary; may be scalars for 1D
@@ -1143,14 +1145,14 @@ errors:
%ds1 = ( x => $x, xnerr => $xn, xperr => $xp,
y => $y );
- limits( [ \%ds1 ], { VecKeys => [ 'x <xnerr >xperr', 'y' ] } );
+ limits( [ \%ds1 ], { VecKeys => [ 'x <xnerr >xperr', 'y' ] } );
For one-sided error bars, specify a column just for the side to
be plotted:
%ds1 = ( x => $x, xnerr => $xn,
y => $y, yperr => $yp );
- limits( [ \%ds1 ], { VecKeys => [ 'x <xnerr', 'y >yperr' ] } );
+ limits( [ \%ds1 ], { VecKeys => [ 'x <xnerr', 'y >yperr' ] } );
Data in hashes with different keys follow the same paradigm:
@@ -1223,7 +1225,7 @@ set transformations, the latter will override it. To explicitly
indicate that a specific data set element has no transformation
(normally only needed if C<Trans> is used to specify a default) set
the transformation subroutine reference to C<undef>. In this case,
-the entire quad of data element, negative error, positive error, and
+the entire quad of data element, negative error, positive error, and
transformation subroutine must be specified to avoid confusion:
[ $x, $xn, $xp, undef ]
@@ -1238,7 +1240,7 @@ of keys, preceded by the C<&> character:
%ds1 = ( x => $x, xerr => $xerr, xtrans => \&log10,
y => $y, yerr => $yerr );
- limits( [ \%ds1, \%ds2 ],
+ limits( [ \%ds1, \%ds2 ],
{ VecKeys => [ 'x =xerr &xtrans', 'y =yerr' ] });
limits( [ \%ds1 => 'x =xerr &xtrans', 'y =yerr' ] );
@@ -1253,11 +1255,11 @@ element, the latter will take precedence. For example,
limits( [ \%ds1 ], { Trans => [ \&exp ] });
# resolves to sqrt
- limits( [ \%ds1 ], { Trans => [ \&exp ],
+ limits( [ \%ds1 ], { Trans => [ \&exp ],
VecKeys => [ 'x =xerr &trans2' ] });
# resolves to log10
- limits( [ \%ds1 => '&trans1' ], { Trans => [ \&exp ],
+ limits( [ \%ds1 => '&trans1' ], { Trans => [ \&exp ],
VecKeys => [ 'x =xerr &trans2' ] });
@@ -1321,7 +1323,7 @@ the bounds (determined above) by a fractional amount:
$max = $axis->{max} + $expand;
The fraction may be specified in the C<%attr> hash with the
-C<RangeFrac> key. It defaults to C<0.05>.
+C<RangeFrac> key. It defaults to C<0.05>.
Because this is a symmetric expansion, a limit of C<0.0> may be
transformed into a negative number, which may be inappropriate. If
@@ -1436,13 +1438,13 @@ but there are data sets which don't have the data and you'd rather
not have to explicitly indicate that, set the C<KeyCroak> attribute
to zero. For example,
- limits( [ { x => $x }, { x => $x1, xerr => $xerr } ],
+ limits( [ { x => $x }, { x => $x1, xerr => $xerr } ],
{ VecKeys => [ 'x =xerr' ] } );
will generate an error because the first data set does not have
an C<xerr> key. Resetting C<KeyCroak> will fix this:
- limits( [ { x => $x }, { x => $x1, xerr => $xerr } ],
+ limits( [ { x => $x }, { x => $x1, xerr => $xerr } ],
{ VecKeys => [ 'x =xerr' ], KeyCroak => 0 } );
View
18 INSTALL
@@ -197,3 +197,21 @@ a bug report (see the BUGS file for directions).
configure process (e.g., the perl Makefile.PL stage),
you can set the environment variable PERL_MM_USE_DEFAULT
to 1 so the default values are taken automatically.
+
+* For some versions of MinGW gcc (on win32 perl platforms),
+ gcc crashes during the build of Primitive.o (or Ufunc.o).
+ The problem appears to be related to the -O3 optimize
+ option. If you edit the Makefile created in the affected
+ code directory to change '-O3' to '-g3' that should allow
+ the build to complete successfully. E.g.:
+
+ cd PDL-2.4.11 # or whatever the build dir is
+ perl Makefile.PL # configure the build
+ make
+ # ... gcc dies building Primitive.o ...
+ cd Basic/Primitive
+ vi Makefile # change -O3 to -g3 w favorite editor
+ cd ../..
+ make
+ # ... gcc should now succeed in building Primitive.o ...
+
View
55 Known_problems
@@ -1,9 +1,20 @@
The following issues have been reported with this version of PDL:
+- Some systems have reported build failures that appear to be
+ a result of missing pthread_getspecific in library calls.
+
+ If you see this, please report via the perldl mailing list to
+ help us determine the origin of the probem and fix it.
+ A workaround is to set WITH_POSIX_THREADS => 0, by editing
+ the perldl.conf file.
+
+
- Multiple subtest failures in t/gd_oo_tests.t have been
seen in CPAN Testers reports, they appear to be on 64bit
- BSD operating systems compiled for AMD processors.
+ BSD operating systems compiled for AMD processors. Sf.net
+ bug #3518190 "t/gd_oo_tests.t fails for AMD64" tracks this
+ issue.
- A change in perl-5.14 on how the 'x' operator works affects
@@ -20,8 +31,7 @@ The following issues have been reported with this version of PDL:
Please see
http://mailman.jach.hawaii.edu/pipermail//pdl-porters/2012-February/004426.html
- for a more detailed discussion and additional alternative
- work-arounds.
+ for a more detailed discussion and additional work-arounds.
- On MS Windows, perl 5.14 (and perhaps later), it is reported that
@@ -31,6 +41,12 @@ The following issues have been reported with this version of PDL:
PDL::Graphics::PLplot separately.
+- Some versions of MinGW gcc (used to compile for win32 perls)
+ crash in compilation of large, PP-generated files. The work-
+ around is to disable optimization for those file. See the
+ INSTALL file for a hand fix.
+
+
- The current Ctrl-C logic in the PDL shells (pdl2 and perldl)
doesn't work the same with the perl's new "safe signals". A
workaround to the problem is to set the PERL_SIGNALS environment
@@ -38,14 +54,6 @@ The following issues have been reported with this version of PDL:
for details and any future status.
-- The PDL build process checks for white space in the build
- directory as that is known to cause problems for some modules
- and asks you if you wish to continue [default is yes].
-
- NOTE: You can avoid the interactive prompts by setting the
- environment variable PERL_MM_USE_DEFAULT to true (e.g., 1).
-
-
- The Perl debugger for perls 5.10.1 through 5.14.x has a new
"feature" leading to false fails for lvalue subroutines when
run under the debugger. If you need to debug such code with
@@ -56,21 +64,13 @@ The following issues have been reported with this version of PDL:
($tmp = $piddle->slice('0:10')) .= 100; # work around perl -d "feature"
The problem is understood and it appears that the error has
- been replaced by a warning for perl-5.15.1. NOTE: the work-
- around is 100% effective---but ugly.
-
-
-- Changes in perl-5.16.x may break some existing PDL usage of
- lvalue subs for this release. It appears that the issue may
- have been avoided upstream by the perl developer. Need to
- check.
+ been replaced by a warning with perl-5.15.1 and is fixed in
+ perl-5.16.0. NOTE: the work-around is ugly but effective.
-- Multiline q'' constructs in the pdl2 shell now work correctly
- but you'll need to avoid using the q abbreviation for quit
- in pdl2 (at least until the multi-line plugin in Devel::REPL
- can be updated appropriately). If you do get "stuck" in a q
- quit attempt, just type Ctrl-D to exit the shell.
+- Multiline q'' constructs are broken in the Devel::REPL versions
+ 1.003012 and 1.003013 so you'll need to use perldl or avoid
+ splitting quoted strings across lines. A fix is being investigated.
- The demo 3d and 3d2 windows do not close (can not be closed)
@@ -121,19 +121,16 @@ The following issues have been reported with this version of PDL:
- The following SourceForge bugs are outstanding at time of the
- PDL-2.4.10_005 release:
+ PDL-2.4.11_001 release:
+ 3528231 t/slatec.t subtest 8 fails w/ BADVAL_USENAN=1
3524081 t/inline-comment.t subtest 3 fails for cygwin
3518190 t/gd_oo_tests.t fails for AMD64
- 3516600 pdl_from_string.t fails w/ BADVAL_USENAN=1
3515759 PDL::GIS::Proj doesn't buidl with proj-4.8.0
3509400 pp_def, pp_line_numbers,..not found by pdldoc
3503566 pdl2 enters infinite loop on DWIMPerl
- 3479009 Slice does not like whitespace
- 3476648 PDL build of HTML docs fails on recent bleed Perl
3475075 t/pic_16bit.t subtest fails
3465663 perldl.conf OPTIMIZE option doesn't work
- 3460886 t/flexraw_fortran.t test failures
3363406 PDL::Minuit build can't make libminuit.a
3316394 'help funname' fails to show multiple function names
3314708 PDL install does not install scantree.pl
View
2 MANIFEST
@@ -728,7 +728,7 @@ t/ica.t
t/image2d.t
t/imagend.t
t/imagergb.t
-t/inline-comment-test.t
+# t/inline-comment-test.t
t/inlinepdlpp.t
t/interp.t
t/interp_slatec.t
View
5 Perldl2/Profile/Perldl2.pm
@@ -7,7 +7,7 @@ package PDL::Perldl2::Profile::Perldl2;
use Moose;
use namespace::clean -except => [ 'meta' ];
-$PDL::Perldl2::Profile::Perldl2::VERSION = 0.006;
+$PDL::Perldl2::Profile::Perldl2::VERSION = 0.007;
with 'Devel::REPL::Profile';
@@ -71,6 +71,7 @@ sub apply_profile {
$repl->eval('package main');
$repl->eval('use PDL');
+ $repl->eval('use PDL::Config');
$repl->eval('use PDL::Dbg');
$repl->eval('use PDL::Doc::Perldl');
$repl->eval('use PDL::IO::Dumper');
@@ -199,6 +200,8 @@ EOD
$plug =~ s/^.*Plugin::/ /;
push @plugins, $plug if $repl->does($pl);
}
+ # Need smarter display of plugins, fill out the line
+ # and list CompletionDrivers under Completion
$repl->print(join "\n", sort(@plugins));
$repl->print("\n");
}
View
6 Perldl2/pdl2
@@ -22,8 +22,12 @@ BEGIN {
if ($@) {
my ($perldl) = $0;
$perldl =~ s/pdl2$/perldl/;
- warn "pdl2: Devel::REPL version $minversion not found, running perldl instead...\n";
+ warn "pdl2: Devel::REPL version $minversion not found, running '$perldl' instead...\n";
do $perldl;
+ warn "pdl2: could not 'do $perldl'\n";
+ $perldl =~ s{^[^/\\]*[/\\]}{};
+ do $perldl;
+ die "pdl2: could not 'do $perldl'\n";
}
}
View
109 Release_Notes
@@ -1,4 +1,4 @@
-Release Notes for PDL 2.4.10_005 --------------------------
+Release Notes for PDL 2.4.11_001 --------------------------
General Notes:
@@ -18,6 +18,111 @@ General Notes:
cpan shell may be used by specifying the distribution
path rather than just the module name, e.g.:
+ cpan> get CHM/PDL-2.4.11_001.tar.gz
+ cpan> make CHM/PDL-2.4.11_001.tar.gz
+ cpan> test CHM/PDL-2.4.11_001.tar.gz
+ cpan> look CHM/PDL-2.4.11_001.tar.gz
+
+
+Highlights:
+
+ * TBD
+
+
+
+Release Notes for PDL 2.4.11 -----------------------------
+
+General Notes:
+
+ * This is a point release of PDL to support the coming perl
+ 5.16.0 release.
+
+ +---------------------------------------------------------------+
+ | BE WARNED: This release includes an update to the internal, |
+ | C-level PDL API and will require that you re-build any PP or |
+ | XS modules. Do not upgrade or install over an existing PDL |
+ | installation unless you are prepared to do so!!! |
+ +---------------------------------------------------------------+
+
+
+Highlights:
+
+ * A new implementation mapflex and mapfraw routines provides
+ memory-mapped IO for all platforms including win32 systems.
+
+ * The new memory mapped IO support is implemented using
+ File::Map so version 0.47 has been added as a required
+ dependency to force automated testing so an automated build
+ will need this dependency installed.
+
+ NOTE: For systems having POSIX mmap, a manual build of
+ PDL will automatically use the legacy implementation.
+
+ * Various cleanup to existing code to fix warnings generated
+ by perl versions 5.15.x and higher.
+
+ Remove deprecation warning in PGPLOT/Window/Window.pm
+ complex.pd - fix attempts to overload '<=>=' and '=>'
+
+ * Sf.net bugs fixed:
+
+ 3518253 Make PDL::flat work under perl 5.16 (thanks sprout!)
+ 3516600 pdl_from_string.t fails w/ BADVAL_USENAN=1
+ 3487569 PDL::IO::Misc : rcols problem (thanks bperret!)
+ 3476648 PDL build of HTML docs fails on recent bleed Perl
+
+ * Other bugs fixed:
+
+ Fix check for glutRunning logic for imag2d
+ Fixed a bug in cat's error reporting.
+ Added lvalue awareness to whereND
+
+ * New and improved tests have been added to the test suite.
+
+ Tests t/gd_oo_tests.t and t/inline-comment-test.t are
+ skipped for BSD platforms (see sf.net bugs #3518190 and
+ #3524081 to track their issues).
+
+ * New support for multi-line comments in PP code. See docs for
+ PDL::PP for details (e.g., pdldoc PP).
+
+ * Various enhancements to barf/croak output and messages to make
+ error reports and stack traces more useful and readable.
+
+ * There is a new changes (or Changes) target for the PDL Makefile
+ which is a convenience target that allows one to regenerate the
+ Changes file from git.
+
+
+
+Release Notes for PDL 2.4.10_005 --------------------------
+
+General Notes:
+
+ +---------------------------------------------------------------+
+ | BE WARNED: This release includes an update to the internal, |
+ | C-level PDL API and will require that you re-build all the |
+ | PP modules. Do not install over an existing PDL installation |
+ | unless you are prepared to do so!!! |
+ +---------------------------------------------------------------+
+
+ * A.k.a. PDL-2.4.11 release candidate 2 with support for
+ perl 5.16.0. Please test!
+
+ - It is a snapshot of the current git development tree
+ and everything may not work correctly or have complete
+ documentation.
+
+ - These release notes may not be fully complete. Please
+ see Changes (from the git log) for full details.
+
+ - All tests may not pass, especially ones corresponding
+ to issues in Known_problems.
+
+ - Manual build/install is recommended although the
+ cpan shell may be used by specifying the distribution
+ path rather than just the module name, e.g.:
+
cpan> get CHM/PDL-2.4.10_005.tar.gz
cpan> make CHM/PDL-2.4.10_005.tar.gz
cpan> test CHM/PDL-2.4.10_005.tar.gz
@@ -26,7 +131,7 @@ General Notes:
Highlights:
- * TBD
+ * See PDL-2.4.11 release notes above
View
2 t/flexraw.t
@@ -14,7 +14,7 @@ use Test::More tests => 12;
use PDL;
use File::Temp qw(tempdir);
-$PDL::debug = 1;
+$PDL::debug = 0;
# Get a temporary directory and file name, which obviously we'll need for testing
# saving and reading of data.
View
40 t/flexraw_fortran.t
@@ -30,25 +30,27 @@ my $null = $^O =~ /win32/i ? ' 2>nul' : ' 2>/dev/null';
BEGIN{
- my $ntests = 29;
- my $datalen;
- $datalen = length($data);
-
- unless ( $PDL::Config{WITH_SLATEC} ) {
- plan skip_all => "Skipped tests as F77 compiler not found";
- } elsif ($Config{archname} =~ /(x86_64|ia64)/) {
- plan skip_all => "Skipped tests for 64 bit architecture: $1";
- } elsif ($datalen > 70) {
- plan skip_all => "TEMPDIR path too long for f77 ($datalen chars), skipping all tests";
- } else {
- eval " use ExtUtils::F77; ";
- if ( $@ ) {
- plan skip_all => "Skip all tests as ExtUtils::F77 not found";
- exit 0;
- } else {
- plan tests => $ntests;
- }
- }
+ my $ntests = 29;
+ my $datalen;
+ $datalen = length($data);
+
+ eval " use PDL::Slatec; ";
+ my $loaded = ($@ ? 0 : 1);
+ unless ( $loaded ) {
+ plan skip_all => "Skipped tests as F77 compiler not found";
+ } elsif ($Config{archname} =~ /(x86_64|ia64)/) {
+ plan skip_all => "Skipped tests for 64 bit architecture: $1";
+ } elsif ($datalen > 70) {
+ plan skip_all => "TEMPDIR path too long for f77 ($datalen chars), skipping all tests";
+ } else {
+ eval " use ExtUtils::F77; ";
+ if ( $@ ) {
+ plan skip_all => "Skip all tests as ExtUtils::F77 not found";
+ exit 0;
+ } else {
+ plan tests => $ntests;
+ }
+ }
# Configuration
# Get ExtUtils::F77 if run in either PDL/t/ or PDL/
View
3 t/limits_round.t
@@ -60,6 +60,7 @@ for my $test ( @round_tests )
{
my $down = round_pow( down => $test->[0] );
my $up = round_pow( up => $test->[0] );
+ my $eps = abs($test->[0]) > 1 ? abs($test->[0])/1.0e-6 : 1.0e-6;
- ok( approx($test->[1],$down) && approx($test->[2],$up), 'round_pow('. $test->[0] .')' );
+ ok( approx($test->[1],$down,$eps) && approx($test->[2],$up,$eps), 'round_pow('. $test->[0] .')' );
}
View
6 t/limits_trans_err.t
@@ -12,8 +12,8 @@ BEGIN {
}
};
-TODO: {
- local $TODO = 'Needs to use approx() for float tests';
+## TODO: { # I think this has been fixed
+## local $TODO = 'Needs to use approx() for float tests';
$x1 = pdl( 1, 2, 3 );
$x2 = pdl( 2, 3, 4 );
@@ -41,4 +41,4 @@ TODO: {
is_deeply( \@range, [ log10(0.5), log10(5+0.5) ], 'illegal errbar lower bounds' );
-}
+## }

0 comments on commit b7ab80b

Please sign in to comment.
Something went wrong with that request. Please try again.