finallywordle #61
Merged
finallywordle #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Ishwarendra
requested changes
Oct 23, 2023
Contributor
Ishwarendra
left a comment
Ishwarendra
left a comment
There was a problem hiding this comment.
Also complete black doesn;t look too good. Try to keep light background for now to match other games and activities.
src/styles/pages/games/Wordle.css
Outdated
Comment on lines
4
to
5
| width: 100vw; | ||
| height: 100vh; |
Contributor
There was a problem hiding this comment.
Don't hardcode these values.
There should not be any horizontal scrollbars.
src/styles/pages/games/Wordle.css
Outdated
| color: white; | ||
| } | ||
|
|
||
| body { |
Contributor
There was a problem hiding this comment.
dont' add css to body, h1, div p and similar tags that can affect other components as well.
src/styles/pages/games/Wordle.css
Outdated
| color: white; | ||
| } | ||
|
|
||
| .board { |
Contributor
There was a problem hiding this comment.
Name css class like wordleBoard instead of board.
Contributor
Author
|
@Ishwarendra can you check now??? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
can you check if its fine?