Modifyworld not being called soon enough to deny items

[bacon-avenger]

I am not sure if this is a bukkit problem or not. I have a suspicion that it is.

bukkit-1.2.3-R0.2-2050
PEX 1.19.1

For example, with -modifyworld.items.have.384, an experience bottle in the players inventory is removed, but only after they use it or switch slots on their hot bar.

This poses a problem when in creative mode, as the player can place the bottle in their inventory and use it before modifyworld catches it. If modifyworld is configured to drop the item, the player can keep picking it up, throw it again, have it drop, then pick it up again and keep repeating this, making this an XP exploit.

[Psithief]

Most likely something changed in the bukkit API and ModifyWorld needs to change to match it!!

ModifyWorld needs to catch whatever event is now being created for enchantment bottles that are thrown.

[Psithief]

@bacon-avenger I made you a plugin. Well, I made it for me, but you can have it too.

import org.bukkit.entity.EntityType;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.ProjectileLaunchEvent;
import org.bukkit.plugin.java.JavaPlugin;

public class LaunchPrevention extends JavaPlugin implements Listener {
    @Override
    public void onEnable() {
        this.getServer().getPluginManager().registerEvents(this, this);
    }

    @EventHandler
    public void preventLaunches(ProjectileLaunchEvent event) {
        if (event.getEntityType() == EntityType.THROWN_EXP_BOTTLE) 
            event.setCancelled(true);
    }
}

The link to the compiled version of this plugin has been removed.

[timirvin]

Thank you Psithief, this also helped me out. Thank you sir.

[bacon-avenger]

Ooo, excellent, thank you psi!

[bacon-avenger]

You know, I had a thought.

With the plugin that psi made, I think that extending modifyworld to hook the ProjectileLaunchEvent. Call the node modifyworld.throw or something. I think this would be a great addition to modifyworld.

[Psithief]

I had that same thought, but work on PEX has not been very visible lately so I didn't bring it up.

[bacon-avenger]

Well, I know that t3hk0d3 has been at least logging into github (he edited a line or two I added to the wiki).

I know that everyone is busy, but some kind of word would be nice. :)

[t3hk0d3]

@bacon-avenger

the player can keep picking it up

You can -modifyworld.items.(pickup|drop|have).384

[bacon-avenger]

t3hk0d3, good to see you are still alive! We were wondering if we were going to have to start checking the boot in a bunch of cars or something. ;)

facepalm

That's right, the pickup node. That would definitely slow them down and make it rather impractical. However, I'm going to have to point out that it doesn't stop the main issue where they can put it out of the creative inventory and at least have it until they use it or change the active item on the hotbar.

But as I mentioned previously, I don't know if it's a bukkit thing or a modifyworld thing. :)

[fugue2005]

@Psithief can you release that launch prevention plugin, i can't seem to find anything else like it and could really use it on my server.

[Psithief]

I reuploaded it to the link above.

[fugue2005]

Thank you, you have no idea how long this has been plaguing me