Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vfs-cache-max-size and vfs-cache-mode #20

Merged
merged 10 commits into from Apr 28, 2019

Conversation

6 participants
@robertbaker
Copy link
Collaborator

commented Apr 27, 2019

Added more/ better notes and defaults.

BTW vfs-cache settings have had 0 effect and thus only currently affected gcrypt mounts.

This PR changes it so the cache mode is shared on all mounts.

Currently cache mode is set to write on the crypt mounts, that change was made a few months ago due to a user bug report, however prior to that change it used to be off for crypt mounts. It's always been off for unencrypted mounts.

This PR changes the existing behavior, this is reverting the crypt mounts to have cache mode off again, which should be fine for most people. I only enabled write in the first place was because of a user report where the error would be resolved by changing the cache mode, however that user may have been doing things outside of normal operations. Regardless, it should be tested with cache mode off when using encrypt.

if there is a problem where you want crypt mount to have a different cache mode than the unencrypt mount. I could add a 2nd cache mode setting, but perhaps it would be better to check if encrypt is used, then default to "write" instead. Are tdrive and tcrypt are used at the same time if using encrypted?

robertbaker added some commits Apr 27, 2019

@robertbaker

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 27, 2019

@Admin9705 please review and test

@Admin9705 Admin9705 merged commit 903e430 into PGBlitz:v8.6 Apr 28, 2019

@Admin9705

This comment has been minimized.

Copy link
Member

commented Apr 28, 2019

works fine. nice add!

@ookla-ariel-ride

This comment has been minimized.

Copy link
Contributor

commented Apr 28, 2019

bazarr requires the write mode enabled, this isn't doing something outside of normal operations.

@antigravity83

This comment has been minimized.

Copy link

commented Apr 28, 2019

Agree with @ookla-ariel-ride. Bazaar smashes your drive and triggers API bans without cache.

@robertbaker

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 29, 2019

@ookla-ariel-ride @antigravity83 What I meant is it's not needed for the core apps, and thus not a default. It's actually a disadvantage to have it on, so the PG default will be set to "off". It's always been off for unencrypted mounts.

it's only needed for bazarr because it opens the files for reading and writing .For those that use bazarr or other programs that write while reading, you can now set the cache mode to be compatible with this software.

@robertbaker robertbaker deleted the robertbaker:patch-1 branch Apr 29, 2019

@antigravity83

This comment has been minimized.

Copy link

commented Apr 29, 2019

@robertbaker Ah ok, so you can redeploy with VFS cache active if you use Bazarr?

@robertbaker

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 29, 2019

@antigravity83 yes, it's now configurable in the vfs options in 8.6.x

@Admin9705

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

outstanding work @robertbaker i can tell the difference :D

@Davst

This comment has been minimized.

Copy link

commented Apr 30, 2019

For people that aren't aware of Bazaar issues, is it included in the deploy script of Bazaar to set cache on?

If not that should be considered.

@Admin9705

This comment has been minimized.

Copy link
Member

commented May 1, 2019

so robert, i changed the 72h on my install to 1h and turn the thing onto full and everything instantly plays. my new stuff constantly buffers with it set to 72h for some reason, i think prior i had 2 minutes. but awesome job on that cache settings. makes a difference @robertbaker

@robertbaker

This comment has been minimized.

Copy link
Collaborator Author

commented May 2, 2019

@m1lkman

This comment has been minimized.

Copy link

commented May 2, 2019

for those of us using encrypted mounts what are the recommended vfs settings now with the latest release?

@robertbaker

This comment has been minimized.

Copy link
Collaborator Author

commented May 3, 2019

@Admin9705 So I just reviewed and I forgot to edit the drive services in the PR. So cache mode itself has had 0 affect so far... oops

Did you test that with encrypt or unencrypt? Odd that the max age would affect things when the cache was either set to 'write' or 'off'

@robertbaker

This comment has been minimized.

Copy link
Collaborator Author

commented May 3, 2019

@m1lkman writes should probably be on by default for everybody, this offers max compat and it's needed for bazarr or if you enabled use nfo files in arr.

We all should do some testing on various configs once my PRs get merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.