Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cache mode options #24

Merged
merged 5 commits into from May 10, 2019

Conversation

2 participants
@robertbaker
Copy link
Collaborator

commented May 9, 2019

No description provided.

@robertbaker

This comment has been minimized.

Copy link
Collaborator Author

commented May 9, 2019

@Admin9705 I found the issue with the last set of PRs and fixed it.

@robertbaker

This comment has been minimized.

Copy link
Collaborator Author

commented May 10, 2019

@Admin9705 There may be 1 slight breaking change here and that's due to me moving the size prefixes from being hardcoded in the service files, to be a sizeSuffix var in the mountNumbers.

This means that the var value of 128 will now be stored as "128M", before it was stored as "128". This change is needed for the "off" value, b/c prior to this change off would have been "offM", which won't work.

So if existing vars are not updated to have the size-suffix stored, if a user redeploys without resetting the vars, rclone will default to K without the size specified.

I'm thinking a few if statements to check for M, G, or H in the var file and if it's not there append it, that should do it. So I made a migration check in the variables.sh file. This should detect old values and reset them.

This PR is g2g.

@Admin9705 Admin9705 merged commit 0fa4862 into PGBlitz:v8.6 May 10, 2019

@Admin9705

This comment has been minimized.

Copy link
Member

commented May 10, 2019

great work as always @robertbaker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.