Skip to content

CI: Switch intel build to ifx#183

Merged
danielhollas merged 9 commits into
masterfrom
ci-setup-fortran
Oct 26, 2024
Merged

CI: Switch intel build to ifx#183
danielhollas merged 9 commits into
masterfrom
ci-setup-fortran

Conversation

@danielhollas

@danielhollas danielhollas commented Oct 24, 2024

Copy link
Copy Markdown
Contributor

Partially addresses #176

Instead of testing with the old intel compiled (ifort) let's test with the new LLVM-based ifx.

  • other random minor cleanups

@codecov

codecov Bot commented Oct 24, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.83%. Comparing base (0a5d9f3) to head (f089dff).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #183   +/-   ##
=======================================
  Coverage   92.83%   92.83%           
=======================================
  Files          47       47           
  Lines        6785     6785           
  Branches      762      762           
=======================================
  Hits         6299     6299           
  Misses        474      474           
  Partials       12       12           
Flag Coverage Δ
unittests 21.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@danielhollas danielhollas changed the title CI: Switch to testing with ifx CI: Switch intel build to ifx Oct 24, 2024
path: ~/pfunit/build/installed
# To force a pFUnit rebuild (bust the cache), make a change to install_pfunit.sh
key: ${{ runner.os }}-ubuntu20.04-pfunit-gfortran${{ env.GCC_V }}-${{ hashFiles('dev_scripts/install_pfunit.sh') }}
save-always: true

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This option is deprecated (and is likely not working as intented anyway)

strategy:
fail-fast: false
matrix:
gcc_v: [9, 11, 12]

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have one less build. The optimized builds never caught any issues. At some point I'll switch to just having a one of these.

Comment thread tests/SHAKE/NUM_THRE
@@ -0,0 +1 @@
12

@danielhollas danielhollas Oct 24, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some numerical differences in the ifx build in the restart files for this test, so we decrease required numerical accuracy to 1e-12. The NUM_THRE file is read in the tests/numdiff.py script.

Comment thread water_potentials/ps.cpp
// two body parameters
const double reoh = 0.958649;
const double thetae = 104.3475;
// const double thetae = 104.3475;

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got a compiler warning that this param is not used.

sudo apt-get install ${{ env.APT_PACKAGES }}
source /opt/intel/oneapi/setvars.sh
printenv >> $GITHUB_ENV
- uses: fortran-lang/setup-fortran@v1

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now I haven't switched the gfortran builds to this GH action since it does not support gfortran v7.

@JanosJiri Are some Prague clusters still on gcc-7?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prague cluster status:
Krypton: gcc version 10.2.1 20210110 (Debian 10.2.1-6)
Neon: gcc version 4.7.2 (Debian 4.7.2-5)
Argon: gcc version 4.4.5 (Debian 4.4.5-8)

Argon is almost dead, Neon is still used but Polách...

@JanosJiri JanosJiri left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

sudo apt-get install ${{ env.APT_PACKAGES }}
source /opt/intel/oneapi/setvars.sh
printenv >> $GITHUB_ENV
- uses: fortran-lang/setup-fortran@v1

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prague cluster status:
Krypton: gcc version 10.2.1 20210110 (Debian 10.2.1-6)
Neon: gcc version 4.7.2 (Debian 4.7.2-5)
Argon: gcc version 4.4.5 (Debian 4.4.5-8)

Argon is almost dead, Neon is still used but Polách...

@danielhollas danielhollas merged commit 7ab1dd6 into master Oct 26, 2024
@danielhollas danielhollas deleted the ci-setup-fortran branch October 26, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants