Surface floating-point operation errors in Github CI#49
Merged
Conversation
danielhollas
changed the title
danielhollas
force-pushed
the
its-a-trap
branch
from
32d9d9f to
9b162ce
Compare
Codecov Report
@@ Coverage Diff @@
## master #49 +/- ##
==========================================
+ Coverage 59.71% 59.78% +0.07%
==========================================
Files 36 36
Lines 5575 5575
==========================================
+ Hits 3329 3333 +4
+ Misses 2246 2242 -4
|
Contributor
|
#48 fixed, rebased, ready to merge. |
Contributor
Author
|
Thanks! Weird, this PR does not touch any Fortran code so coverage should not be affected. Maybe some bad interaction between the compiler flags? I'll take a look. |
danielhollas
force-pushed
the
its-a-trap
branch
from
ebfec93 to
e73bed0
Compare
danielhollas
force-pushed
the
its-a-trap
branch
from
e73bed0 to
aa72cea
Compare
danielhollas
force-pushed
the
its-a-trap
branch
from
aa72cea to
73edee6
Compare
Contributor
|
Codecov now looks ok, ready to merge? |
Contributor
Author
|
I'm working on cleaning up those compiler warnings, wanted to do that as
part of this PR, but maybe I'll do it in a separate one.
Dne po 4. 1. 2021 10:35 dop. uživatel Jiri Suchan <notifications@github.com>
napsal:
… Codecov now looks ok, ready to merge?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#49 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACIY64P2B42AJQ57YZTW353SYGDXVANCNFSM4VBTXM2Q>
.
|
Contributor
Author
|
Merging now, will open a new PR that will fix the compiler warnings. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To catch issues like #48. The tests are now failing, as they should, so this should be merged only once the #48 is addressed.
Some context can be find here:
https://docs.oracle.com/cd/E19957-01/805-4940/6j4m1u7pj/index.html
FYI: @suchanj