Fix compilation with ifort#70
Conversation
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
=======================================
Coverage 68.98% 68.99%
=======================================
Files 38 38
Lines 5688 5689 +1
=======================================
+ Hits 3924 3925 +1
Misses 1764 1764
|
danielhollas
force-pushed
the
ifort-fixes
branch
from
463d59b to
a86ead6
Compare
|
|
||
| # Heuristic: if .vimrc exists, we presume we're dealing with a VIM user :-) | ||
| if [[ -f /home/$USER/.vimrc ]];then | ||
| if [[ -f ~/.vimrc ]];then |
There was a problem hiding this comment.
Durham clusters don't have /home/$USER/ directory. :-)
| print '(a)', ' ' | ||
| end subroutine print_logo | ||
|
|
||
| end subroutine init |
There was a problem hiding this comment.
print_runtime_info has a system call to ldd. The fortran compiler is not happy with the fact that we also have a namelist called system. Putting print_runtime_info() outside of init() fixes that.
| @@ -1,4 +1,3 @@ | |||
| CXX = g++ | |||
There was a problem hiding this comment.
This should not be hardcoded, but defined in make.vars
|
@suchanj can you take a look? btw: Big congrats on the poster prize! 🎉 I think I'll be submitting more PRs in the next few weeks. LMK if you're down for reviewing them, or whether I should merge them without review. Thanks! |
danielhollas
force-pushed
the
ifort-fixes
branch
from
a86ead6 to
09b4453
Compare
|
@danielhollas Thanks! Regarding the new PRs - I'd like to stay in the loop but don't want to hinder the merging process by taking time. So I would propose that you merge whatever you need, but do not immediately delete the branches from repository so they would still be visible 👍 |
|
@suchanj awesome, thanks! Sound good. I think some of them will be just some minor refactoring and cleanups. For anything bigger I'll always wait for you to take a look. |
danielhollas
force-pushed
the
ifort-fixes
branch
from
09b4453 to
d48ef48
Compare
These are all ugly hacks that disable some (fairly essential) functionalities. Long term we need to get rid of GNU/gfortran specific stuff altogether.
danielhollas
force-pushed
the
ifort-fixes
branch
from
d48ef48 to
dd56922
Compare
2 participants
These are all ugly hacks for now, but I don't have time to fix these things properly for now.
Long term we need to get rid of all GNU/GCC-specific stuff altogether.