TC tests fixes#71
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #71 +/- ##
=======================================
Coverage 68.99% 68.99%
=======================================
Files 38 38
Lines 5689 5689
=======================================
Hits 3925 3925
Misses 1764 1764
|
danielhollas
commented
Sep 29, 2021
| # in the TERAPI*/test.sh scripts. | ||
| cleanup() { | ||
| kill_processeses $* | ||
| kill_processes $* |
Contributor
Author
There was a problem hiding this comment.
Whoops, I hate the word 'process' 😑
danielhollas
force-pushed
the
tc-tests-fixes
branch
2 times, most recently
from
3b40dfa to
a297b10
Compare
Contributor
Author
|
@suchanj this one is also ready for review. Nothing very interesting here... |
danielhollas
force-pushed
the
tc-tests-fixes
branch
from
a297b10 to
1f32ba8
Compare
suchanj
approved these changes
Oct 4, 2021
- Sometimes when a test failed, it left running processes behind. I made sure that the trap command and cleanup functions are defined BEFORE we start tc_server or ABIN. Now this should behave better, even if we manually stop running test suite in the middle. - Bump MPICH version in GitHub CI
danielhollas
force-pushed
the
tc-tests-fixes
branch
from
1f32ba8 to
6428dce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes if a test failed, it left running processes behind.
I made sure that the trap command and cleanup functions are defined
BEFORE we start tc_server or ABIN. Now this should behave better,
even if we manually stop running test suite in the middle.
Bump MPICH version in GitHub CI
This PR is based on #70, I'll rebase this when #70 gets merged.