Add test for Morse potential + refactor#84
Merged
Conversation
danielhollas
added
refactor
danielhollas
force-pushed
the
potential-tests
branch
from
e6bed5d to
8e75218
Compare
Codecov Report
@@ Coverage Diff @@
## master #84 +/- ##
==========================================
- Coverage 75.75% 71.12% -4.64%
==========================================
Files 40 40
Lines 5705 5742 +37
==========================================
- Hits 4322 4084 -238
- Misses 1383 1658 +275
|
danielhollas
force-pushed
the
potential-tests
branch
from
8e75218 to
13c1d38
Compare
Now that we have some intentionally failing tests, redirecting stderr make the output nicer and less confusing. Downside is if something fails, we need to go look into abin.out, which is potentially problematic in GHA. We should have some automatic artifact uploading when for failing tests.
danielhollas
force-pushed
the
potential-tests
branch
from
120df95 to
3a239a2
Compare
danielhollas
changed the title
suchanj
approved these changes
Mar 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a test for the Morse potential and little cleanup of the code for analytical potentials.
cc @suchanj