Skip to content

Add MTS test#93

Merged
danielhollas merged 9 commits into
masterfrom
test-mts
Mar 28, 2022
Merged

Add MTS test#93
danielhollas merged 9 commits into
masterfrom
test-mts

Conversation

@danielhollas

@danielhollas danielhollas commented Mar 25, 2022

Copy link
Copy Markdown
Contributor

I verified that the multiple time-stepping integration with the reference potential works for classical MD. Even though the code is writen to support PIMD, it does not currently work. The original plan was to implement the Path Integral ring contraction scheme of O. Maršálek, but I never got around to finish it.

Also cleaned up sample input files and extended the REMD test to test that ABIN gracefully stops when an empty file EXIT is present (this is how ExitAbin.sh works).

@danielhollas danielhollas added the testing Any changes to Github Actions or testing scripts. label Mar 25, 2022
@danielhollas danielhollas self-assigned this Mar 25, 2022
@codecov

codecov Bot commented Mar 25, 2022

Copy link
Copy Markdown

Codecov Report

Merging #93 (87f2d5d) into master (4867e0c) will increase coverage by 1.00%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
+ Coverage   81.68%   82.69%   +1.00%     
==========================================
  Files          40       40              
  Lines        5820     5807      -13     
==========================================
+ Hits         4754     4802      +48     
+ Misses       1066     1005      -61     
Impacted Files Coverage Δ
src/init.F90 68.49% <62.50%> (+1.35%) ⬆️
src/force_abin.F90 64.24% <100.00%> (+0.18%) ⬆️
src/force_bound.F90 87.30% <100.00%> (ø)
src/forces.F90 96.81% <100.00%> (+7.05%) ⬆️
src/modules.F90 37.60% <0.00%> (+0.80%) ⬆️
src/arrays.F90 100.00% <0.00%> (+5.95%) ⬆️
src/abin.F90 92.24% <0.00%> (+7.75%) ⬆️
src/mdstep.F90 98.90% <0.00%> (+24.17%) ⬆️

@danielhollas danielhollas requested a review from suchanj March 26, 2022 04:01
This test was failing with Intel2018
due to minor numerical difference,
so decreasing number of minimization steps might help.
@danielhollas danielhollas merged commit 36613ed into master Mar 28, 2022
@danielhollas danielhollas deleted the test-mts branch March 28, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Any changes to Github Actions or testing scripts.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants