Skip to content

SH: test simple velocity rescaling#99

Merged
danielhollas merged 5 commits into
masterfrom
sh-test-vrescale
Mar 31, 2022
Merged

SH: test simple velocity rescaling#99
danielhollas merged 5 commits into
masterfrom
sh-test-vrescale

Conversation

@danielhollas

@danielhollas danielhollas commented Mar 30, 2022

Copy link
Copy Markdown
Contributor

Two new tests for testing hopping with simple velocity rescale and frutrated hopping code paths.
The new tests also cover the corrected decoherence correction (which we still need to make default, will do that in a separate PR).

This brings test coverage of SH close to 100%, except for some error handling paths.

@danielhollas danielhollas added the testing Any changes to Github Actions or testing scripts. label Mar 30, 2022
@danielhollas danielhollas self-assigned this Mar 30, 2022
@codecov

codecov Bot commented Mar 30, 2022

Copy link
Copy Markdown

Codecov Report

Merging #99 (c866447) into master (f857ec8) will increase coverage by 0.88%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
+ Coverage   86.06%   86.95%   +0.88%     
==========================================
  Files          42       42              
  Lines        5813     5809       -4     
==========================================
+ Hits         5003     5051      +48     
+ Misses        810      758      -52     
Impacted Files Coverage Δ
src/surfacehop.F90 94.43% <100.00%> (+10.49%) ⬆️
src/sh_integ.F90 97.02% <0.00%> (+3.40%) ⬆️

@danielhollas danielhollas requested a review from suchanj March 30, 2022 23:37
@danielhollas danielhollas marked this pull request as ready for review March 30, 2022 23:44
@danielhollas danielhollas merged commit 780dc4a into master Mar 31, 2022
@danielhollas danielhollas deleted the sh-test-vrescale branch March 31, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Any changes to Github Actions or testing scripts.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants