SH: test simple velocity rescaling#99
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #99 +/- ##
==========================================
+ Coverage 86.06% 86.95% +0.88%
==========================================
Files 42 42
Lines 5813 5809 -4
==========================================
+ Hits 5003 5051 +48
+ Misses 810 758 -52
|
This also tests the correct decoherence correction.
be7c666 to
2ad70ab
Compare
2ad70ab to
b1a72f6
Compare
6e63f12 to
b3235d3
Compare
suchanj
approved these changes
Mar 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two new tests for testing hopping with simple velocity rescale and frutrated hopping code paths.
The new tests also cover the corrected decoherence correction (which we still need to make default, will do that in a separate PR).
This brings test coverage of SH close to 100%, except for some error handling paths.