Ability to report processing time for each rule-per-file

[mvorisek]

This is a feature request to show slow tests like phpunit with johnkary/phpunit-speedtrap.

Usecase: to quickly identify issues like #4656

[kubawerlos]

@mvorisek how would you imagine this to be done?

[mvorisek]

@kubawerlos Very simple, measure rule apply time and then report the rule name, file name and the elapsed time if the elapsed time is greater than some treshold.

Note, that this feature request is for reporting AFTER rule is executed. To discover rules that never finish or take very long time use verbose log, as there is no way (in single non-async thread) to display some message during the rule execution. For verbose logging, see #4372

What do you think?

[kubawerlos]

Rulesets or just rules?

I was thinking once about adding something here: https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/v2.16.1/src/Runner/Runner.php#L150

Maybe some events before starting fixing a file and after finishing.

[mvorisek]

Rulesets or just rules?

You are right, rule not ruleset (I also updated the comment above to prevent any misunderstanding.)

Maybe some events before starting fixing a file and after finishing.

👍 Yes

[mvorisek]

It seems that verbose level (like --verbose=3 or -vvv) is completely unsupported, even if documented in:
https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/2.16/doc/usage.rst - because of this, I think it is a bug

--verbose=3 ends up with error:

In ArgvInput.php line 204:

  [Symfony\Component\Console\Exception\RuntimeException]
  The "--verbose" option does not accept a value.

-vvv seems to no affect the verbosity at all, -vvvvvvvvvvv does not hep too

[mvorisek]

closing as performance issues are currently rarely problematic

[mvorisek]

I am reopening this issue as when introducing PHP CS Fixer to some larger project it has to be rerun localy many times and if I would be able to list slow rules, it would help - save developer time - to disable them temporary.

[Wirone]

I've renamed the issue as it has nothing to do with tests 😉.

[github-actions]

Since this issue has not had any activity within the last 90 days, I have marked it as stale.

The purpose of this action is to enforce backlog review once in a while. This is mostly for maintainers and helps with keeping repository in good condition, because stale issues and PRs can accumulate over time and make it harder for others to find relevant information. It is also possible that some changes has been made to the repo already, and issue or PR became outdated, but wasn't closed for some reason. This action helps with periodic review and closing of such stale items in automated way.

You may let maintainers handle this or verify current relevancy by yourself, to help with re-triage. Any activity will remove stale label so it won't be automatically closed at this point.

I will close it if no further activity occurs within the next 30 days.

[mvorisek]

not stale

[github-actions]

Since this issue has not had any activity within the last 90 days, I have marked it as stale.

The purpose of this action is to enforce backlog review once in a while. This is mostly for maintainers and helps with keeping repository in good condition, because stale issues and PRs can accumulate over time and make it harder for others to find relevant information. It is also possible that some changes has been made to the repo already, and issue or PR became outdated, but wasn't closed for some reason. This action helps with periodic review and closing of such stale items in automated way.

You may let maintainers handle this or verify current relevancy by yourself, to help with re-triage. Any activity will remove stale label so it won't be automatically closed at this point.

I will close it if no further activity occurs within the next 30 days.

[github-actions]

The fact this was automatically closed doesn't mean that the idea got rejected - it simply didn't get any priority for way too long to keep it open. If you're still interested in this, please let as know, we can consider re-opening it.