bug: Align all the arrows inside the same array#6590
Merged
julienfalque merged 1 commit intoPHP-CS-Fixer:masterfrom Nov 21, 2022
Merged
bug: Align all the arrows inside the same array#6590julienfalque merged 1 commit intoPHP-CS-Fixer:masterfrom
julienfalque merged 1 commit intoPHP-CS-Fixer:masterfrom
Conversation
Contributor
Author
|
Friendly ping, |
julienfalque
approved these changes
Nov 21, 2022
Member
|
Thank you @VincentLanglet. |
This was referenced Dec 18, 2022
|
Is it possible to revert this change? See this issue for details: #6716 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #4395
Close #5546
With my recent contributions (#6559, #6515, #6450, #6445, #6444), I really improved the way binary operator are of different "scope" use different placeholder.
For instance
So it would be now possible to align the operator of a same scope, even if it's not in the following line.
I never saw someone reporting an issue for
not fixed to
but for
=>it's kinda different.I created #4395, got some thumbs up, and there is also #5546
I see three solutions:
align_scoped_single_spaceI think this is the worst solution because
=>, sincefixed to
wasn't requested so far/could be weird.
I'd like to heard your opinion on this if you have time @SpacePossum (cc @julienfalque)