docs: Fix docs for disabled rules in rulesets#6679
Merged
julienfalque merged 1 commit intoPHP-CS-Fixer:masterfrom Nov 17, 2022
Merged
docs: Fix docs for disabled rules in rulesets#6679julienfalque merged 1 commit intoPHP-CS-Fixer:masterfrom
julienfalque merged 1 commit intoPHP-CS-Fixer:masterfrom
Conversation
Pull Request Test Coverage Report for Build 3421913941
💛 - Coveralls |
jrmajor
reviewed
Nov 8, 2022
julienfalque
force-pushed
the
docs-rulesets-disabled-rules
branch
from
aeefcb1 to
5a78926
Compare
keradus
reviewed
Nov 8, 2022
Member
There was a problem hiding this comment.
like the strict check against explicitly disabled rule by comparing to false.
keradus
approved these changes
Nov 8, 2022
Member
keradus
left a comment
keradus
left a comment
There was a problem hiding this comment.
I like it. I wonder if we can cover with tests somehow?
Member
Author
IMO the generated docs are the best test cases we can have, not sure we need something else. |
Member
Author
|
Actually the docs should still document the fact that rulesets do disable those rules. I'm going to rework these changes a bit. |
julienfalque
force-pushed
the
docs-rulesets-disabled-rules
branch
from
5a78926 to
b019825
Compare
julienfalque
changed the title
kubawerlos
approved these changes
Nov 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.