Make static data providers that are not using dynamic calls #6696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3557808078
💛 - Coveralls |
keradus
approved these changes
Dec 5, 2022
kubawerlos
deleted the
make_static_data_providers_that_are_not_using_dynamic_calls
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-static data providers will be deprecated in PHPUnit 10 and removed in PHPUnit 11.
This PR makes static all data providers that are not using dynamic calls - basically, nothing to review here, this PR simply adds
static893 times.Data providers using dynamic calls will need that call to be changed - will be done in separate PR as changes might be up for some discussion.