Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Add no_null_property_initialization rule to @Symfony #6876

Merged
merged 1 commit into from Apr 3, 2023
Merged

feature: Add no_null_property_initialization rule to @Symfony #6876

merged 1 commit into from Apr 3, 2023

Conversation

yguedidi
Copy link
Contributor

@yguedidi yguedidi commented Apr 2, 2023 •
edited

After a discussion with @stof, this rule should be part of the @Symfony PHP-CS-Fixer ruleset.
Symfony code base is (almost, see symfony/symfony#49896) following it already

@yguedidi yguedidi mentioned this pull request Apr 2, 2023
Merged
@yguedidi yguedidi marked this pull request as ready for review April 2, 2023 01:37
@keradus
Copy link
Member

keradus commented Apr 2, 2023

Thanks for the PR!
I'm eager to merge it when we have PR in Symfony repo merged or someone from Sf stakeholder confirms it here.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4586193308

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.004%
Totals Coverage Status
Change from base Build 4584756507: 0.0%
Covered Lines: 22734
Relevant Lines: 24444
💛 - Coveralls

nicolas-grekas added a commit to symfony/symfony that referenced this pull request Apr 3, 2023
@nicolas-grekas
minor #49896 Apply no_null_property_initialization PHP-CS-Fixer rule …
e70f359 
…(yguedidi)

This PR was merged into the 6.3 branch.

Discussion
----------

Apply no_null_property_initialization PHP-CS-Fixer rule

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

After a discussion with `@stof`, this rule should be part of the ``@Symfony`` PHP-CS-Fixer ruleset.
This PR apply the rule on the Symfony code base.
see PHP-CS-Fixer/PHP-CS-Fixer#6876 for the PR on PHP-CS-Fixer

Commits
-------

2320c2a Apply no_null_property_initialization PHP-CS-Fixer rule
symfony-splitter pushed a commit to symfony/notifier that referenced this pull request Apr 3, 2023
@nicolas-grekas
minor #49896 Apply no_null_property_initialization PHP-CS-Fixer rule …
d56f46e 
…(yguedidi)

This PR was merged into the 6.3 branch.

Discussion
----------

Apply no_null_property_initialization PHP-CS-Fixer rule

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

After a discussion with `@stof`, this rule should be part of the ``@Symfony`` PHP-CS-Fixer ruleset.
This PR apply the rule on the Symfony code base.
see PHP-CS-Fixer/PHP-CS-Fixer#6876 for the PR on PHP-CS-Fixer

Commits
-------

2320c2a906 Apply no_null_property_initialization PHP-CS-Fixer rule
symfony-splitter pushed a commit to symfony/validator that referenced this pull request Apr 3, 2023
@nicolas-grekas
minor #49896 Apply no_null_property_initialization PHP-CS-Fixer rule …
e047c78 
…(yguedidi)

This PR was merged into the 6.3 branch.

Discussion
----------

Apply no_null_property_initialization PHP-CS-Fixer rule

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

After a discussion with `@stof`, this rule should be part of the ``@Symfony`` PHP-CS-Fixer ruleset.
This PR apply the rule on the Symfony code base.
see PHP-CS-Fixer/PHP-CS-Fixer#6876 for the PR on PHP-CS-Fixer

Commits
-------

2320c2a906 Apply no_null_property_initialization PHP-CS-Fixer rule
symfony-splitter pushed a commit to symfony/routing that referenced this pull request Apr 3, 2023
@nicolas-grekas
minor #49896 Apply no_null_property_initialization PHP-CS-Fixer rule …
8ca22cb 
…(yguedidi)

This PR was merged into the 6.3 branch.

Discussion
----------

Apply no_null_property_initialization PHP-CS-Fixer rule

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

After a discussion with `@stof`, this rule should be part of the ``@Symfony`` PHP-CS-Fixer ruleset.
This PR apply the rule on the Symfony code base.
see PHP-CS-Fixer/PHP-CS-Fixer#6876 for the PR on PHP-CS-Fixer

Commits
-------

2320c2a906 Apply no_null_property_initialization PHP-CS-Fixer rule
symfony-splitter pushed a commit to symfony/doctrine-bridge that referenced this pull request Apr 3, 2023
@nicolas-grekas
minor #49896 Apply no_null_property_initialization PHP-CS-Fixer rule …
1136e6b 
…(yguedidi)

This PR was merged into the 6.3 branch.

Discussion
----------

Apply no_null_property_initialization PHP-CS-Fixer rule

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

After a discussion with `@stof`, this rule should be part of the ``@Symfony`` PHP-CS-Fixer ruleset.
This PR apply the rule on the Symfony code base.
see PHP-CS-Fixer/PHP-CS-Fixer#6876 for the PR on PHP-CS-Fixer

Commits
-------

2320c2a906 Apply no_null_property_initialization PHP-CS-Fixer rule
symfony-splitter pushed a commit to symfony/framework-bundle that referenced this pull request Apr 3, 2023
@nicolas-grekas
minor #49896 Apply no_null_property_initialization PHP-CS-Fixer rule …
225d916 
…(yguedidi)

This PR was merged into the 6.3 branch.

Discussion
----------

Apply no_null_property_initialization PHP-CS-Fixer rule

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

After a discussion with `@stof`, this rule should be part of the ``@Symfony`` PHP-CS-Fixer ruleset.
This PR apply the rule on the Symfony code base.
see PHP-CS-Fixer/PHP-CS-Fixer#6876 for the PR on PHP-CS-Fixer

Commits
-------

2320c2a906 Apply no_null_property_initialization PHP-CS-Fixer rule
@yguedidi
Copy link
Contributor Author

yguedidi commented Apr 3, 2023

@keradus PR merged on Symfony side

@keradus keradus merged commit bdc7de5 into PHP-CS-Fixer:master Apr 3, 2023
13 checks passed
@yguedidi yguedidi deleted the add-no_null_property_initialization-to-symfony branch April 3, 2023 21:04
@vladvildanov vladvildanov mentioned this pull request Jun 7, 2023
Merged
symfony-splitter pushed a commit to symfony/framework-bundle that referenced this pull request Jul 28, 2023
@nicolas-grekas
minor #49896 Apply no_null_property_initialization PHP-CS-Fixer rule …
1f878ef 
…(yguedidi)

This PR was merged into the 6.3 branch.

Discussion
----------

Apply no_null_property_initialization PHP-CS-Fixer rule

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

After a discussion with `@stof`, this rule should be part of the ``@Symfony`` PHP-CS-Fixer ruleset.
This PR apply the rule on the Symfony code base.
see PHP-CS-Fixer/PHP-CS-Fixer#6876 for the PR on PHP-CS-Fixer

Commits
-------

2320c2a906 Apply no_null_property_initialization PHP-CS-Fixer rule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yguedidi @keradus @coveralls