HHVM support #157

Closed
mnapoli opened this Issue Mar 19, 2014 · 2 comments

Comments

Projects
None yet
1 participant
@mnapoli
Member

mnapoli commented Mar 19, 2014

Tests are now passing for the latest HHVM version except one. The failing test is because of an expected bug in PHP which HHVM doesn't seem to reproduce:

https://travis-ci.org/mnapoli/PHP-DI/jobs/20882256

Once this is solved, HHVM should be moved out of the "allowed failure" in Travis config and support should be maintained in the future.

@mnapoli mnapoli added this to the 4.1 milestone Mar 19, 2014

@mnapoli mnapoli added the enhancement label Mar 19, 2014

@mnapoli

This comment has been minimized.

Show comment
Hide comment
@mnapoli

mnapoli Apr 2, 2014

Member

It looks like a bug in HHVM: facebook/hhvm#2282

Member

mnapoli commented Apr 2, 2014

It looks like a bug in HHVM: facebook/hhvm#2282

@mnapoli

This comment has been minimized.

Show comment
Hide comment
@mnapoli

mnapoli Apr 2, 2014

Member

I removed the test: it was testing a situation relying on a PHP bug, so no regrets dropping it. Now all tests should pass on HHVM.

Member

mnapoli commented Apr 2, 2014

I removed the test: it was testing a situation relying on a PHP bug, so no regrets dropping it. Now all tests should pass on HHVM.

@mnapoli mnapoli referenced this issue Apr 2, 2014

Merged

4.1 #155

8 of 8 tasks complete

@mnapoli mnapoli closed this Apr 2, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment