Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HHVM support #157

Closed
mnapoli opened this issue Mar 19, 2014 · 2 comments
Closed

HHVM support #157

mnapoli opened this issue Mar 19, 2014 · 2 comments
Labels
Milestone

Comments

@mnapoli
Copy link
Member

@mnapoli mnapoli commented Mar 19, 2014

Tests are now passing for the latest HHVM version except one. The failing test is because of an expected bug in PHP which HHVM doesn't seem to reproduce:

https://travis-ci.org/mnapoli/PHP-DI/jobs/20882256

Once this is solved, HHVM should be moved out of the "allowed failure" in Travis config and support should be maintained in the future.

@mnapoli mnapoli added this to the 4.1 milestone Mar 19, 2014
@mnapoli mnapoli added the enhancement label Mar 19, 2014
@mnapoli
Copy link
Member Author

@mnapoli mnapoli commented Apr 2, 2014

It looks like a bug in HHVM: facebook/hhvm#2282

mnapoli added a commit that referenced this issue Apr 2, 2014
@mnapoli
Copy link
Member Author

@mnapoli mnapoli commented Apr 2, 2014

I removed the test: it was testing a situation relying on a PHP bug, so no regrets dropping it. Now all tests should pass on HHVM.

@mnapoli mnapoli mentioned this issue Apr 2, 2014
Merged
8 of 8 tasks complete
mnapoli added a commit that referenced this issue Apr 2, 2014
@mnapoli mnapoli closed this Apr 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.