Autowiring and Annotations do not work for `DI\object()` inside arrays

[mopahle]

Example code:

<?php
require 'vendor/autoload.php';

class A {
  public function __construct(B $b) {}
}

class B {
  /**
   * @Inject
   */
  public function test() {
    echo "Autowiring and Annotations work.";
  }
}

$builder=new DI\ContainerBuilder();
$builder->useAnnotations(true);
$builder->addDefinitions([
  'test'=>[DI\object(A::class)]
]);
$container=$builder->build();

try {
  $container->get('test');
}
catch (Exception $e)
{
  echo $e->getMessage();
}

Executing the code above gives the following output:

Error while resolving test[0]. Entry  cannot be resolved: The parameter 'b' of A::__construct has no value defined or guessable
Full definition:
Object (
    class = A
    scope = singleton
    lazy = false
)

changing the definitions to $builder->addDefinitions(['test'=>DI\object(A::class)]); works as expected.

[juliangut]

Is DI\object inside an array a correct usage? I mean you're already using DI\object to create the resolvable

[mopahle]

Having only one item in an array may be not really a usecase. But how would you solve something like this without an array:

$builder->addDefinitions([
  'logappenders'=>[
    DI\object(Logappender1::class),
    DI\object(Logappender2::class),
    DI\object(Logappender3::class),
  ]
])

and maybe with a second defintion:

$builder->addDefinitions([
    'logappenders'=>DI\add([
        DI\object(Logappender4::class),
    ])
])

[mnapoli]

That's weird indeed, thanks for the great bug report. The usage seems valid to me and I think I can see why it's not working… After a very quick look I'm not sure what the best fix would be, I'll try to have a look at it soon.

As a workaround (in the meantime):

[
  'test' => [get(A::class)],
  A::class => object(A::class),
];

[tuanmh]

I got the same error here. Any plan to fix it?

[mnapoli]

I know what causes the bug (ArrayDefinition doesn't trigger autowiring on sub-definitions) but from what I remember it's not an easy one to fix and I don't have a lot of time available to work on it at the moment (publishing the last Slim bridge should have been 2 weeks ago for example).

For anyone wanting to have a look at it: ArrayDefinition should me made to implement HasSubDefinition based on its items. If an item implements HasSubDefinition then it should trigger a sub-definition resolution (i.e. the autowiring). Problem: an array definition could have 0, 1 or many sub-definitions because it can have many items (and the interface doesn't allow "many sub-definitions" for now). Also it needs to be done with as little performance impact as possible (though the cache should minimize that).

[tuanmh]

Thanks for your quick response & detail guides on this 👍. I'll see if I can help :)

[leonbobster]

Just a hack, sorry if it completely against your vision: https://github.com/PHP-DI/PHP-DI/pull/426/files
Any feedback is welcome ;-)

[mnapoli]

Hi everyone, this issue has been indirectly fixed by the replacement of DI\object() with DI\create() and DI\autowire(). The good news too is that since the container can now be compiled (#494) performances will not be affected.