/PHP-DI

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DI\InvokerInterface (in favor of Invoker\InvokerInterface) #516

Closed
mnapoli opened this Issue Jul 29, 2017 · 0 comments

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
  6.0
1 participant
@mnapoli
@mnapoli
Member

mnapoli commented Jul 29, 2017 •
edited

Invoker\InvokerInterface exists since version 5 and is defined in the PHP-DI/Invoker package.

The DI\InvokerInterface is useless, it's empty and extends Invoker\InvokerInterface.

Removing it is like removing DI\ContainerInterface in favor of PSR-11 or container-interop for example (until there's a PSR for invokers…).

@mnapoli mnapoli added this to the 6.0 milestone Jul 29, 2017

mnapoli added a commit that referenced this issue Jul 29, 2017

@mnapoli
#516 Remove DI\InvokerInterface in favor of Invoker\InvokerInterface 
`Invoker\InvokerInterface` exists since version 5 and is defined in the [PHP-DI/Invoker](https://github.com/PHP-DI/Invoker/blob/master/src/InvokerInterface.php) package.

The `DI\InvokerInterface` is useless, it's empty and extends `Invoker\InvokerInterface`.

Removing it is like removing `DI\ContainerInterface` in favor of PSR-11 or container-interop for example (until there's a PSR for invokers…).
Loading status checks…
1074adb

@mnapoli mnapoli added the refactoring label Jul 29, 2017

@mnapoli mnapoli referenced this issue Jul 29, 2017

Merged

#516 Remove DI\InvokerInterface in favor of Invoker\InvokerInterface #518

@mnapoli mnapoli closed this in #518 Jul 30, 2017

mnapoli added a commit that referenced this issue Jul 30, 2017

@mnapoli
Merge pull request #518 from PHP-DI/remove-invoker-interface 
#516 Remove DI\InvokerInterface in favor of Invoker\InvokerInterface
Loading status checks…
3d57084
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment