New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nikic/php-parser 4 for PHP-DI/PHP-DI 6? #585
Comments
Thanks, feel free to send a pull request if you have time. |
I've had a look at this myself. It seems that Until such times as |
|
It seems that support has already been added in jeremeamia/super_closure#104 but it has not been released yet. |
SuperClosure 2.4.0 has been released almost right after your comment. |
Just tested, seems that the new holdup is phpstan, lol. Version 0.9.2 requires php-parser at ^3.1 and not seeing any PR's there for upping it, might look at that one later |
It seems to be scheduled for the v0.10 milestone. See: phpstan/phpstan#859 |
As your version constraint would become |
Yep no blocker here, thanks for the feedback it's fixed! |
Hello!
I've just installed Symfony 4 and would like to use it with the currently latest version of PHP-DI, the
v6
.So the problem is, that one of the Symfony packages (namely
symfony/maker-bundle
) needs thenikic/php-parser ^4.0
. And this dosn't meet the PHP-DI's requirements defined in itscomposer.json
:The
nikic/PHP-Parser
'sv4
was released18 days ago
. And the PHP-DI'sv6
was released about a week earlier. So is the restriction to the^2.0|^3.0
just outdated and should be extended with^4.0
? If so, could the core developers please update it.Thanks
The text was updated successfully, but these errors were encountered: