New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ContainerBuilder fluent #98

Closed
drdamour opened this Issue Aug 13, 2013 · 2 comments

Comments

Projects
None yet
2 participants
@drdamour
Contributor

drdamour commented Aug 13, 2013

what are your thoughts on turning ContainerBuilder into a fluent interface so you can do something like

$builder = new ContainerBuilder();
$builder->useReflection(false)
   ->useAnotations(true)
   ->setCache(  ...cache );
$container = $builder->build();
@mnapoli

This comment has been minimized.

Show comment
Hide comment
@mnapoli

mnapoli Aug 13, 2013

Member

Totally agree 👍

Member

mnapoli commented Aug 13, 2013

Totally agree 👍

drdamour added a commit to drdamour/PHP-DI that referenced this issue Sep 1, 2013

mnapoli added a commit that referenced this issue Sep 2, 2013

Merge pull request #105 from drdamour/FluentBuilder
For #98 switched builder to a fluent interface
@mnapoli

This comment has been minimized.

Show comment
Hide comment
@mnapoli

mnapoli Sep 2, 2013

Member

Implemented in 3.4

Member

mnapoli commented Sep 2, 2013

Implemented in 3.4

@mnapoli mnapoli closed this Sep 2, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment