Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ContainerBuilder fluent #98

Closed
drdamour opened this issue Aug 13, 2013 · 2 comments
Closed

Make ContainerBuilder fluent #98

drdamour opened this issue Aug 13, 2013 · 2 comments
Labels
enhancement
Milestone
3.4

Comments

@drdamour
Copy link
Contributor

what are your thoughts on turning ContainerBuilder into a fluent interface so you can do something like

$builder = new ContainerBuilder();
$builder->useReflection(false)
   ->useAnotations(true)
   ->setCache(  ...cache );
$container = $builder->build();
@mnapoli
Copy link
Member

mnapoli commented Aug 13, 2013

Totally agree 👍

drdamour added a commit to drdamour/PHP-DI that referenced this issue Sep 1, 2013
@drdamour
For PHP-DI#98 switched builder to a fluent interface
1141df4
mnapoli added a commit that referenced this issue Sep 2, 2013
@mnapoli
Merge pull request #105 from drdamour/FluentBuilder
0be003a 
For #98 switched builder to a fluent interface
@mnapoli
Copy link
Member

mnapoli commented Sep 2, 2013

Implemented in 3.4

@mnapoli mnapoli closed this as completed Sep 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
3.4
Development

No branches or pull requests
2 participants
@mnapoli @drdamour