New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing "@param" with PHP internal type throws exception #99

Closed
mnapoli opened this Issue Aug 13, 2013 · 2 comments

Comments

Projects
None yet
1 participant
@mnapoli
Member

mnapoli commented Aug 13, 2013

    /**
     * @Inject
     * @param bool $param
     */
    public function method1($param)
    {
        ...
    }

It seems that it throws an exception. Add tests to reproduce, then fix.

Problem: how to fix?

  • have a blacklist of types (bool, int, …) but how to handle edge cases like "MyClass[string]", "String", …
  • don't throw an exception if the type doesn't match a class name: difficult to debug if typo in the class name…

@mnapoli mnapoli referenced this issue Sep 23, 2013

Merged

v3.4 #102

8 of 8 tasks complete
@mnapoli

This comment has been minimized.

Show comment
Hide comment
@mnapoli
Member

mnapoli commented Dec 15, 2013

@mnapoli

This comment has been minimized.

Show comment
Hide comment
@mnapoli

mnapoli Dec 15, 2013

Member

Fixed in 4.0

Member

mnapoli commented Dec 15, 2013

Fixed in 4.0

@mnapoli mnapoli closed this Dec 15, 2013

mnapoli added a commit that referenced this issue Dec 15, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment