Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #96 Handle optional parameters for constructor/method injection #101

Merged
merged 4 commits into from Sep 24, 2013

Conversation

@mnapoli
Copy link
Member

@mnapoli mnapoli commented Aug 13, 2013

Tests reproducing #96, and fix

@mnapoli
Copy link
Member Author

@mnapoli mnapoli commented Sep 8, 2013

Needs more tests maybe

@mnapoli mnapoli mentioned this pull request Sep 23, 2013
8 of 8 tasks complete
Conflicts:
	src/DI/Factory.php
	tests/IntegrationTests/DI/Fixtures/Class1.php
mnapoli added a commit that referenced this pull request Sep 24, 2013
Fix for #96 Handle optional parameters for constructor/method injection
@mnapoli mnapoli merged commit 22356d7 into 3.4 Sep 24, 2013
1 check passed
1 check passed
default The Travis CI build passed
Details
@mnapoli mnapoli deleted the feature/OptionalParameters branch Sep 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.