Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for array-style callable to FunctionCallDefinitionDumper. #180

Merged
merged 1 commit into from Aug 8, 2014

Conversation

@jmalloc
Copy link
Contributor

jmalloc commented Aug 8, 2014

I had a definition failure occur with the following code:

$container->call([$object, 'injectDependencies']);

And the dumper failed with the error message:

ReflectionFunction::__construct() expects parameter 1 to be string, array given

This PR adds explicit report for array callables to the dumper.

@mnapoli mnapoli merged commit b5bae63 into PHP-DI:master Aug 8, 2014
0 of 2 checks passed
0 of 2 checks passed
ci/scrutinizer Scrutinizer: No new issues — Tests: failed
Details
continuous-integration/travis-ci The Travis CI build failed
Details
@mnapoli mnapoli added the bug label Aug 8, 2014
@mnapoli
Copy link
Member

mnapoli commented Aug 8, 2014

Thank you for this quick fix! I have merged manually and fixed the short array in the tests so that it runs on PHP 5.3 too.

I have just released v4.2.2 (https://github.com/mnapoli/PHP-DI/releases/tag/4.2.2) :)

@jmalloc jmalloc deleted the jmalloc:method-dumper branch Aug 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.