Add an 'edit this' button to the documentation #325

Merged
merged 1 commit into from Sep 16, 2015

Conversation

Projects
None yet
2 participants
@jdreesen
Contributor

jdreesen commented Sep 16, 2015

Wasn't sure if it's better to link to GitHub's markdown preview page, or to the form where you can directly edit the document.

The latter will show a message that you have to fork the repository first, if you haven't already done so:
github-edit

So, which one do you prefer? I chose the second one for now.

Closes #132

@mnapoli mnapoli added this to the 5.2 milestone Sep 16, 2015

@mnapoli

This comment has been minimized.

Show comment
Hide comment
@mnapoli

mnapoli Sep 16, 2015

Member

Perfect! The second solution seems like a good choice to me too.

capture d ecran 2015-09-16 a 22 49 32

Member

mnapoli commented Sep 16, 2015

Perfect! The second solution seems like a good choice to me too.

capture d ecran 2015-09-16 a 22 49 32

mnapoli added a commit that referenced this pull request Sep 16, 2015

Merge pull request #325 from jdreesen/edit-button
Add an 'edit this' button to the documentation

@mnapoli mnapoli merged commit 43cfd8e into PHP-DI:master Sep 16, 2015

3 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 84.691%
Details

@jdreesen jdreesen deleted the jdreesen:edit-button branch Sep 16, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment