-
-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inject dependencies and requested entry name in factory parameters [retake of #345] #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current Definition can be injected via type-hinting: DI\Definition\Definition or as a second parameter if no type-hinting is present. Docs and tests updated accordingly.
…into factories That allows to keep definitions an internal implementation details. If definitions are refactored later on, factories will not be broken. Also factories have no reason to know about definitions, they just want the request entry name (ISP).
2 tasks
2 tasks
Nice optimization passing container in constructor and resolving directly, then you can avoid |
Thanks! Time to merge then :) |
mnapoli
added a commit
that referenced
this pull request
Nov 29, 2015
Inject dependencies and requested entry name in factory parameters [retake of #345]
Looks very nice 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains #345 and #333.
The differences with #345:
DI\Factory\RequestedEntry
) to know the requested definition name: that replaces the injection ofDefinition
instances. The reason for that is to avoid coupling user factories with definitions which are an implementation detail of PHP-DI. If definitions ever change, it will not break factories.Example to get the requested entry name:
Example to inject other services:
TODO:
This is the last feature planned for 5.2, after that it's release time!