Remove definition dumpers: definitions can now cast to string directly #416

Merged
merged 1 commit into from May 29, 2016

Conversation

Projects
None yet
1 participant
@mnapoli
Member

mnapoli commented May 26, 2016

That allows to remove 9 classes (plus 8 test classes) and a lot of code that was not very useful at all. It has been refactored into something much simpler: definitions can be simply cast to string.

TODO:

  • profiling -> no differences (which is to be expected since dumping a definition is a debugging operation only)

@mnapoli mnapoli added the refactoring label May 26, 2016

@mnapoli mnapoli added this to the 5.3 milestone May 29, 2016

Remove definition dumpers: definitions can now cast to string directly
That allows to remove 9 classes (plus 8 test classes) and a lot of code that was not very useful at all. It has been refactored into something much simpler: definitions can be simply cast to string.

@mnapoli mnapoli merged commit 279c4f0 into master May 29, 2016

5 checks passed

Scrutinizer 1 new issues, 8 updated code elements
Details
StyleCI The StyleCI analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.8%) to 83.902%
Details

@mnapoli mnapoli deleted the remove-dumpers branch May 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment