Cache wildcard definitions #429

Merged
merged 1 commit into from Jul 10, 2016

Conversation

Projects
None yet
1 participant
@mnapoli
Member

mnapoli commented Jul 10, 2016

That will allow iterating way less items when looking for definitions in DefinitionArray.

TODO:

  • profile improvement

    Got approximately 50% performance improvement on DefinitionArray::getDefinition() on http://externals.io (saved close to 1 ms), going from 7.4% of the total execution time to 3.3% -> This is definitely useful.

  • understand why tests fail

@mnapoli mnapoli added the enhancement label Jul 10, 2016

@mnapoli mnapoli added this to the 5.4 milestone Jul 10, 2016

Cache wildcard definitions
That will allow iterating way less items when looking for definitions in DefinitionArray.

@mnapoli mnapoli merged commit ea145d2 into master Jul 10, 2016

5 checks passed

Scrutinizer 2 new issues, 1 updated code elements
Details
StyleCI The StyleCI analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 83.765%
Details

@mnapoli mnapoli deleted the cache-wildcard-definitions branch Jul 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment