Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for defining factory parameters (contd.) #430

Merged
merged 1 commit into from Jul 14, 2016

Conversation

@predakanga
Copy link
Contributor

predakanga commented Jul 10, 2016

Continuing on from #428, with a squashed rebase

@mnapoli mnapoli added the enhancement label Jul 10, 2016
@mnapoli mnapoli added this to the 5.4 milestone Jul 10, 2016
@predakanga
Copy link
Contributor Author

predakanga commented Jul 10, 2016

Oh, and I forgot to mention - I removed the changes to the @exceptionMessage tests, they work great on master now!

@mnapoli mnapoli merged commit 6a8483d into PHP-DI:master Jul 14, 2016
4 checks passed
4 checks passed
Scrutinizer 1 new issues, 3 updated code elements
Details
StyleCI The StyleCI analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.8%) to 84.359%
Details
@mnapoli
Copy link
Member

mnapoli commented Jul 14, 2016

Amazing thanks for the contribution!

@predakanga predakanga deleted the predakanga:fix-362 branch Jul 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.