Fix Factory parameter resolution order, incl. tests #432

Merged
merged 2 commits into from Jul 15, 2016

Conversation

Projects
None yet
2 participants
@predakanga
Contributor

predakanga commented Jul 15, 2016

Fixes #431

Includes a test for another potential edge case: parameters overriding default values

predakanga added some commits Jul 15, 2016

@mnapoli mnapoli added the bug label Jul 15, 2016

@mnapoli mnapoli added this to the 5.4 milestone Jul 15, 2016

@mnapoli

This comment has been minimized.

Show comment
Hide comment
@mnapoli

mnapoli Jul 15, 2016

Member

Looks good to me!

Member

mnapoli commented Jul 15, 2016

Looks good to me!

@mnapoli mnapoli merged commit 9845d40 into PHP-DI:master Jul 15, 2016

4 checks passed

Scrutinizer 1 updated code elements
Details
StyleCI The StyleCI analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.05%) to 84.602%
Details
@mnapoli

This comment has been minimized.

Show comment
Hide comment
@mnapoli

mnapoli Aug 23, 2016

Member

Really sorry for having let your contribution sit idle in the master branch. I have finally gotten around finishing the 5.4 release with the changelog and a blog article. It's all pushed, I'll be announcing it tomorrow but it can be installed with Composer now. Cheers

Member

mnapoli commented Aug 23, 2016

Really sorry for having let your contribution sit idle in the master branch. I have finally gotten around finishing the 5.4 release with the changelog and a blog article. It's all pushed, I'll be announcing it tomorrow but it can be installed with Composer now. Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment