Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Factory parameter resolution order, incl. tests #432

Merged
merged 2 commits into from Jul 15, 2016

Conversation

predakanga
Copy link
Contributor

@predakanga predakanga commented Jul 15, 2016

Fixes #431

Includes a test for another potential edge case: parameters overriding default values

@mnapoli mnapoli added the bug label Jul 15, 2016
@mnapoli mnapoli added this to the 5.4 milestone Jul 15, 2016
@mnapoli
Copy link
Member

@mnapoli mnapoli commented Jul 15, 2016

Looks good to me!

@mnapoli mnapoli merged commit 9845d40 into PHP-DI:master Jul 15, 2016
4 checks passed
@mnapoli
Copy link
Member

@mnapoli mnapoli commented Aug 23, 2016

Really sorry for having let your contribution sit idle in the master branch. I have finally gotten around finishing the 5.4 release with the changelog and a blog article. It's all pushed, I'll be announcing it tomorrow but it can be installed with Composer now. Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants