ensure definitions dump #484

Merged
merged 3 commits into from Apr 29, 2017

Conversation

Projects
None yet
2 participants
@juliangut
Contributor

juliangut commented Apr 26, 2017

Covers #478 and #480

@mnapoli

Thanks, could you also add a line in the changelog?

src/DI/Definition/AliasDefinition.php
@@ -34,11 +34,17 @@ public function __construct($name, $targetEntryName)
$this->targetEntryName = $targetEntryName;
}
+ /**
+ * {@inheritdoc}
+ */

This comment has been minimized.

@mnapoli

mnapoli Apr 28, 2017

Member

The inheritdoc are not necessary as they are the default, I've been removing them in the codebase since they only make the code more complex. Could you remove them?

@mnapoli

mnapoli Apr 28, 2017

Member

The inheritdoc are not necessary as they are the default, I've been removing them in the codebase since they only make the code more complex. Could you remove them?

@@ -8,7 +8,7 @@
* @since 5.0
* @author Matthieu Napoli <matthieu@mnapoli.fr>
*/
-class DecoratorDefinition extends FactoryDefinition implements Definition, HasSubDefinition
+class DecoratorDefinition extends FactoryDefinition implements HasSubDefinition

This comment has been minimized.

@mnapoli

mnapoli Apr 28, 2017

Member

I like the fact that interfaces implemented are explicitly mentioned (else you have to navigate through plenty of files to get to the top interface). Could you revert that?

@mnapoli

mnapoli Apr 28, 2017

Member

I like the fact that interfaces implemented are explicitly mentioned (else you have to navigate through plenty of files to get to the top interface). Could you revert that?

This comment has been minimized.

@juliangut

juliangut Apr 28, 2017

Contributor

I tend to go the other way around, phpstorm's EA extended plugin warns me if I'm missing interface methods

@juliangut

juliangut Apr 28, 2017

Contributor

I tend to go the other way around, phpstorm's EA extended plugin warns me if I'm missing interface methods

src/DI/Definition/InstanceDefinition.php
@@ -26,19 +26,26 @@ class InstanceDefinition implements Definition
/**
* @param object $instance
+ * @param ObjectDefinition $objectDefinition

This comment has been minimized.

@mnapoli

mnapoli Apr 28, 2017

Member

This is redundant with the code, this doesn't need to be documented.

@mnapoli

mnapoli Apr 28, 2017

Member

This is redundant with the code, this doesn't need to be documented.

src/DI/Definition/InstanceDefinition.php
+ public function __toString()
+ {
+ return 'Instance';
+ }

This comment has been minimized.

@mnapoli

mnapoli Apr 28, 2017

Member

Ha nice catch ^^

@mnapoli

mnapoli Apr 28, 2017

Member

Ha nice catch ^^

src/DI/Definition/ValueDefinition.php
public function getName() : string
{
return $this->name;
}
/**
+ * {@inheritdoc}

This comment has been minimized.

@mnapoli

mnapoli Apr 28, 2017

Member

This one should stay because the documentation is really inherited :)

@mnapoli

mnapoli Apr 28, 2017

Member

This one should stay because the documentation is really inherited :)

@juliangut

This comment has been minimized.

Show comment
Hide comment
@juliangut

juliangut Apr 28, 2017

Contributor

I'l try to make the changes and add that line to changelog ASAP

Contributor

juliangut commented Apr 28, 2017

I'l try to make the changes and add that line to changelog ASAP

juliangut added some commits Apr 29, 2017

@mnapoli

This comment has been minimized.

Show comment
Hide comment
@mnapoli

mnapoli Apr 29, 2017

Member

Thanks!

Member

mnapoli commented Apr 29, 2017

Thanks!

@mnapoli mnapoli merged commit fc4c54e into PHP-DI:master Apr 29, 2017

4 checks passed

Scrutinizer 4 updated code elements
Details
continuous-integration/styleci/pr The StyleCI analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 81.835%
Details

@juliangut juliangut deleted the juliangut:definitions_dump branch Jun 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment