Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop container-interop #485

Merged
merged 2 commits into from May 3, 2017
Merged

drop container-interop #485

merged 2 commits into from May 3, 2017

Conversation

juliangut
Copy link
Contributor

Covers #463

composer.json Outdated
"psr/simple-cache": "^1.0",
"php-di/invoker": "^1.3.2",
"php-di/invoker": "dev-master",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^2.0.0 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn't see 2.0 was released

@@ -107,7 +107,6 @@ public function should_be_able_to_resolve_defined_env_variables()
*/
public function should_be_able_to_resolve_undefined_env_variables()
{
// See https://github.com/container-interop/container-interop/issues/37
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this link could stay since it explains why the test is like that (based on a discussion in container-interop).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better suited on a docblock @see

@juliangut
Copy link
Contributor Author

I something missing or incomplete for this PR to be merged?

@mnapoli
Copy link
Member

mnapoli commented May 3, 2017

It's all good thank you!

@mnapoli mnapoli merged commit c77a440 into PHP-DI:master May 3, 2017
@juliangut juliangut deleted the psr11 branch May 3, 2017 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants