Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop container-interop #485

Merged
merged 2 commits into from May 3, 2017
Merged

drop container-interop #485

merged 2 commits into from May 3, 2017

Conversation

@juliangut
Copy link
Contributor

@juliangut juliangut commented Apr 26, 2017

Covers #463

"psr/simple-cache": "^1.0",
"php-di/invoker": "^1.3.2",
"php-di/invoker": "dev-master",

This comment has been minimized.

@mnapoli

mnapoli Apr 28, 2017
Member

^2.0.0 ?

This comment has been minimized.

@juliangut

juliangut Apr 28, 2017
Author Contributor

Sorry, I didn't see 2.0 was released

@@ -107,7 +107,6 @@ public function should_be_able_to_resolve_defined_env_variables()
*/
public function should_be_able_to_resolve_undefined_env_variables()
{
// See https://github.com/container-interop/container-interop/issues/37

This comment has been minimized.

@mnapoli

mnapoli Apr 28, 2017
Member

I think this link could stay since it explains why the test is like that (based on a discussion in container-interop).

This comment has been minimized.

@juliangut

juliangut Apr 29, 2017
Author Contributor

Better suited on a docblock @see

@juliangut
Copy link
Contributor Author

@juliangut juliangut commented May 3, 2017

I something missing or incomplete for this PR to be merged?

@mnapoli
Copy link
Member

@mnapoli mnapoli commented May 3, 2017

It's all good thank you!

@mnapoli mnapoli merged commit c77a440 into PHP-DI:master May 3, 2017
4 checks passed
4 checks passed
Scrutinizer No new issues
Details
continuous-integration/styleci/pr The StyleCI analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.4%) to 82.066%
Details
@juliangut juliangut deleted the juliangut:psr11 branch May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants